Skip to content

Windows API change on GetCurrentProcess is breaking the lib #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexvaut opened this issue Sep 23, 2019 · 2 comments · Fixed by #646
Closed

Windows API change on GetCurrentProcess is breaking the lib #642

alexvaut opened this issue Sep 23, 2019 · 2 comments · Fixed by #646
Labels
bug

Comments

@alexvaut
Copy link

alexvaut commented Sep 23, 2019 •
edited
Loading

On windows 10, just get the last release:

go get github.com/prometheus/client_golang/prometheus/promauto
C:...\github.com\prometheus\client_golang\prometheus\process_collector_windows.go:78:9: assignment mismatch: 2 variables but "golang.org/x/sys/windows".GetCurrentProcess returns 1 values

It seems related to this change: golang/sys@2dccfee
There are other lib broken because of this change: golang/go#34461

go version go1.12.4 windows/amd64
@alexvaut alexvaut mentioned this issue Sep 23, 2019
Closed
@beorn7 beorn7 added the bug label Sep 23, 2019
@zshearin
Copy link

zshearin commented Sep 24, 2019 •
edited
Loading

ran into same problem

@anjiawei1991
Copy link

same problem.

I think upgrade the dependency golang/x/sys in this module and remove the err can fix it

@anjiawei1991 anjiawei1991 mentioned this issue Sep 26, 2019
Closed
beorn7 added a commit that referenced this issue Sep 27, 2019
@beorn7
Update dependencies
eb4edc4 
This should happen now and then anyway, but in this case, it should
also fix #642.

Signed-off-by: beorn7 <[email protected]>
@beorn7 beorn7 mentioned this issue Sep 27, 2019
Merged
@stefantalpalaru stefantalpalaru mentioned this issue Sep 29, 2019
Open
@djdv djdv mentioned this issue Dec 18, 2019
Closed
@lizthegrey lizthegrey mentioned this issue Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@beorn7 @zshearin @alexvaut @anjiawei1991