Skip to content

x/tools/gopls/internal/telemetry: TestTelemetry failures #62161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 19, 2023 · 4 comments
Closed

x/tools/gopls/internal/telemetry: TestTelemetry failures #62161

gopherbot opened this issue Aug 19, 2023 · 4 comments
Assignees
@hyangah
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Aug 19, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/telemetry" && test == "TestTelemetry" && `read stackcounter.* = .*, want one entry`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTelemetry (0.54s)
    telemetry_test.go:60: ReadCounter("gopls/client:vscode") = (0, <nil>), want (1, nil)
    telemetry_test.go:60: ReadCounter("gopls/goversion:1.22") = (0, <nil>), want (1, nil)
    telemetry_test.go:71: read stackcounter("gopls/bug") = (map[string]uint64{}, <nil>), want one entry

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 19, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry" && test == "TestTelemetry"
2023-08-18 14:18 linux-arm64-longtest tools@9425c2e7 go@a9859a7d x/tools/gopls/internal/telemetry.TestTelemetry (log) 
--- FAIL: TestTelemetry (0.54s)
    telemetry_test.go:60: ReadCounter("gopls/client:vscode") = (0, <nil>), want (1, nil)
    telemetry_test.go:60: ReadCounter("gopls/goversion:1.22") = (0, <nil>), want (1, nil)
    telemetry_test.go:71: read stackcounter("gopls/bug") = (map[string]uint64{}, <nil>), want one entry

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 19, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2023
@findleyr
Copy link
Member

CC @hyangah @pjweinb

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.14.0 Aug 24, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/523795 mentions this issue: gopls/internal/telemetry: log timestamp when test fails

gopherbot pushed a commit to golang/tools that referenced this issue Aug 29, 2023
@hyangah
gopls/internal/telemetry: log timestamp when test fails
2926c1f 
We observed a couple of test failures. My current hypothesis is
that the bug is in how countertest.ReadCounter and
countertest.ReadStackCounter read the data. They try to access
the counter values by reading the contents of the mapped file on
disk and parsing them with counter.Parse. They call 'file.rotate'
before reading the files to ensure the file is mapped. However,
if file.rotate ends up actually rotating the underlying file
(due to crossing the UTC day boundary), the counter data may be
flushed out and reset. As we are moving to 'week' instead of 'day'
for file rotation, I don't know how frequently we will encounter
this issue though if this was the root cause. Log the timestamp
when the test fails, to evaluate the hypothesis.

For golang/go#62161

Change-Id: If00b0788b6927640a979d17f8fe888232d27ea09
Reviewed-on: https://go-review.googlesource.com/c/tools/+/523795
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopls-CI: kokoro <[email protected]>
Reviewed-by: Jamal Carvalho <[email protected]>
@adonovan adonovan added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 31, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 9, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023
@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Jan 17, 2024
@findleyr
Copy link
Member

Looks like this is fixed.

@gabyhelp gabyhelp mentioned this issue Sep 27, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.16.0
Development

No branches or pull requests
4 participants
@hyangah @adonovan @gopherbot @findleyr