x/tools/gopls: crash monitoring broken with telemetry.Start

[findleyr]

Originally reported by @danp in #69552: an observed crash was not recorded in telemetry.

Investigating why, I discovered that in https://go.dev/cl/592017, the codepath to the telemetry child started bypassing the call to counter.Open, and so while the crashmonitor does in fact report a crash, this report goes nowhere.

Of course, this indicates a critical gap in testing coverage of telemetry.Start.

It looks like [email protected] has this bug as well, but [email protected] does not (I had a note to self to investigate why we'd not received any crash reports for [email protected]). The go command is unaffected as it wasn't using crash reporting.

Fix incoming.

[gabyhelp]

Related Issues and Documentation

• x/telemetry/config: enable data collection for crash/* counters, for gopls #65696 (closed)
• x/telemetry/cmd/gotelemetry: view/dump commands fail to aggregate `crash/crash` stack counts #65554 (closed)
• x/tools/gopls/internal/telemetry: TestTelemetry failures #62161 (closed)
• x/tools/gopls/internal/telemetry: TestTelemetry failures #69132
• Telemetry in Go 1.23 and beyond > A brief history of Go telemetry > Automated crash reporting

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/616396 mentions this issue: telemetry: fix automated crash reporting using telemetry.Start

[gopherbot]

Change https://go.dev/cl/616415 mentions this issue: gopls: update x/telemetry to pick up fix for golang/go#69681