all: add start of netbsd/arm64 support #29398

coypoop · 2018-12-23T04:42:10Z

This works well enough to run some code natively on arm64, but not well enough for more complicated code. I've been suggested to start a pull request anyway.

Updates #30824

gopherbot · 2018-12-23T04:42:58Z

This PR (HEAD: 0a55384) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-12-23T04:43:46Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-12-23T07:23:53Z

Message from Agniva De Sarker:

Patch Set 1:

Is there an issue tracking this ? If not, might be good to open one and plan this.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-14T03:13:01Z

This PR (HEAD: 06356af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-25T16:15:07Z

Message from Daniel Martí:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:15:08Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=fa917a94

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:19:25Z

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/fa917a94/misc-vet-vetall_8c5364e1.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:22:49Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

1 of 19 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/fa917a94/misc-vet-vetall_8c5364e1.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:25:35Z

Message from Daniel Martí:

Patch Set 4:

Please rebase to fix the vet failure :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:29:46Z

Message from Brad Fitzpatrick:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:29:47Z

Message from Brad Fitzpatrick:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:29:48Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f22b162e

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:34:42Z

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on misc-compile-netbsd:
See https://storage.googleapis.com/go-build-log/f22b162e/misc-compile-netbsd_4f916da2.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T16:37:12Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

2 of 19 TryBots failed:
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/f22b162e/misc-compile-netbsd_4f916da2.log
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/f22b162e/misc-vet-vetall_8a87d971.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T21:26:52Z

Message from Benny Siegert:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-25T22:25:41Z

Message from Brad Fitzpatrick:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T11:30:34Z

This PR (HEAD: bee80d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-20T11:40:24Z

This PR (HEAD: 23426ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-20T12:13:43Z

Message from Benny Siegert:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T12:13:44Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=cb001a47

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T12:16:52Z

Message from Gobot Gobot:

Patch Set 7:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/cb001a47/misc-vet-vetall_4860f931.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T12:22:41Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result-1

3 of 20 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/cb001a47/misc-vet-vetall_4860f931.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/cb001a47/misc-compile-netbsd_11aa8123.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/cb001a47/js-wasm_7d89fd10.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

Currently we support linux and darwin. !linux == darwin. This might be useful for the BSDs.

This works well enough to run basic commands natively.

Allows us to stop whitelisting this error on many OS/arch combinations

gopherbot · 2019-04-20T13:01:23Z

This PR (HEAD: 5e3008f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

coypoop · 2019-04-20T13:02:08Z

sorry, I messed up git stuff. I am adding #31583 to this pull request to see if the try-bots pass then. (I'm not sure if I'm running it right locally)

gopherbot · 2019-04-20T13:16:51Z

Message from Benny Siegert:

Patch Set 8: Run-TryBot+1

Let's try this again

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T13:17:33Z

Message from Gobot Gobot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1c4ca50a

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T13:26:39Z

Message from Gobot Gobot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T13:42:00Z

This PR (HEAD: ebc62b6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-20T14:29:49Z

Message from Benny Siegert:

Patch Set 9: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T14:30:32Z

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3def6e04

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T14:39:38Z

This PR (HEAD: b01b105) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155739 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-20T14:40:57Z

Message from Gobot Gobot:

Patch Set 9: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T14:46:18Z

Message from Benny Siegert:

Patch Set 10: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T14:46:19Z

Message from Gobot Gobot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d8d441a1

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-20T14:55:25Z

Message from Gobot Gobot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/155739.
After addressing review feedback, remember to publish your drafts!

This works well enough to run some code natively on arm64, but not well enough for more complicated code. I've been suggested to start a pull request anyway. Updates #30824 Change-Id: Ib4f63e0e8a9edfc862cf65b5f1b0fbf9a8a1628e GitHub-Last-Rev: b01b105 GitHub-Pull-Request: #29398 Reviewed-on: https://go-review.googlesource.com/c/go/+/155739 Run-TryBot: Benny Siegert <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Benny Siegert <[email protected]>

gopherbot · 2019-04-20T15:03:35Z

This PR is being closed because golang.org/cl/155739 has been merged.

googlebot added the cla: yes label Dec 23, 2018

coypoop force-pushed the netbsd-arm64 branch from 0a55384 to 06356af Compare March 14, 2019 03:12

coypoop mentioned this pull request Mar 14, 2019

all: support netbsd/arm64 #30824

Closed

bradfitz changed the title ~~netbsd/arm64 support~~ all: add netbsd/arm64 support Mar 14, 2019

bradfitz changed the title ~~all: add netbsd/arm64 support~~ all: add start of netbsd/arm64 support Mar 14, 2019

coypoop force-pushed the netbsd-arm64 branch from bee80d1 to 23426ec Compare April 20, 2019 11:39

coypoop added 2 commits April 20, 2019 15:48

Reverse polarity on test.

11713b4

Currently we support linux and darwin. !linux == darwin. This might be useful for the BSDs.

Add netbsd/arm64 as ELF and having /libexec/ld.elf_so as rtld

6d101c4

coypoop added 5 commits April 20, 2019 15:48

Add netbsd/arm64

9518abe

Add netbsd/arm64 support.

9ff01b6

This works well enough to run basic commands natively.

runtime: follow up with CL 167389

04af456

Correct argument size

090034c

runtime: move linux specific code into linux specific files

5e3008f

Allows us to stop whitelisting this error on many OS/arch combinations

coypoop force-pushed the netbsd-arm64 branch from 23426ec to 5e3008f Compare April 20, 2019 13:00

Update copyright years

b01b105

coypoop force-pushed the netbsd-arm64 branch from ebc62b6 to b01b105 Compare April 20, 2019 14:39

gopherbot closed this Apr 20, 2019

bcmills mentioned this pull request Nov 6, 2020

runtime: frequent crashes with "exit status 16962" on netbsd-arm64-bsiegert builder #42422

Closed

all: add start of netbsd/arm64 support #29398

all: add start of netbsd/arm64 support #29398

Conversation

coypoop commented Dec 23, 2018 • edited by bradfitz Loading

gopherbot commented Dec 23, 2018

gopherbot commented Dec 23, 2018

gopherbot commented Dec 23, 2018

gopherbot commented Mar 14, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Mar 25, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

coypoop commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

gopherbot commented Apr 20, 2019

coypoop commented Dec 23, 2018 •

edited by bradfitz

Loading