Skip to content

crypto/x509: fix certificate request creation with RSA-PSS #46029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ycongal-smile
Copy link
Contributor

In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest
is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will
generate a proper RSA-PSS signature.

Pasted from the RSA-PSS handling code in CreateCertificate()

Fixes #45990

@google-cla
Copy link

google-cla bot commented May 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label May 6, 2021
@ycongal-smile
Copy link
Contributor Author

The corporate CLA is still in the process of being signed. This is frustratingly long but we'll do it.

@ycongal-smile
Copy link
Contributor Author

@googlebot I signed it!

@ycongal-smile ycongal-smile marked this pull request as ready for review July 6, 2022 16:13
@google-cla google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jul 7, 2022
@ycongal-smile
Copy link
Contributor Author

Rebased my commits on master and tested again. Still OK.

@cipherboy
Copy link
Contributor

cipherboy commented Sep 16, 2022

@ycongal-smile (I don't work on Golang). You might need a fresh PR to get it mirrored into the proper PR review queue. They don't use GH so if it doesn't get mirrored into https://go-review.googlesource.com/ it won't be reviewed (and I don't see a link here or it in the search feature there).

In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest
is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will
generate a proper RSA-PSS signature.

Pasted from the RSA-PSS handling code in CreateCertificate()

Fixes golang#45990
@ycongal-smile
Copy link
Contributor Author

@ycongal-smile (I don't work on Golang). You might need a fresh PR to get it mirrored into the proper PR review queue. They don't use GH so if it doesn't get mirrored into https://go-review.googlesource.com/ it won't be reviewed (and I don't see a link here or it in the search feature there).

Ok I'll try this. Thanks!

@ycongal-smile
Copy link
Contributor Author

Closing this PR to open a fresh one and hopefully the new one will be picked up by the bots.

@gopherbot
Copy link
Contributor

This PR (HEAD: 2914abc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/431875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@ycongal-smile
Copy link
Contributor Author

Well this was unexpected... I'll reopen then :)

@ycongal-smile ycongal-smile reopened this Sep 19, 2022
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/431875 has been abandoned.

GitHub PR #46029 has been closed.

@gopherbot gopherbot closed this Sep 19, 2022
@cipherboy
Copy link
Contributor

@ycongal-smile Looks like you might need to mark the CL as not abandoned? :/

@ycongal-smile
Copy link
Contributor Author

I opened a new PR here : #55153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto/x509: can't verify signature on RSA-PSS certificate requests it created
3 participants