-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/x509: fix certificate request creation with RSA-PSS #46029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
The corporate CLA is still in the process of being signed. This is frustratingly long but we'll do it. |
239a7c0
to
9cc6138
Compare
9cc6138
to
afe0c14
Compare
@googlebot I signed it! |
afe0c14
to
60efc5c
Compare
Rebased my commits on master and tested again. Still OK. |
@ycongal-smile (I don't work on Golang). You might need a fresh PR to get it mirrored into the proper PR review queue. They don't use GH so if it doesn't get mirrored into https://go-review.googlesource.com/ it won't be reviewed (and I don't see a link here or it in the search feature there). |
In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will generate a proper RSA-PSS signature. Pasted from the RSA-PSS handling code in CreateCertificate() Fixes golang#45990
Ok I'll try this. Thanks! |
60efc5c
to
2914abc
Compare
Closing this PR to open a fresh one and hopefully the new one will be picked up by the bots. |
This PR (HEAD: 2914abc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/431875 to see it. Tip: You can toggle comments from me using the |
Well this was unexpected... I'll reopen then :) |
This PR is being closed because golang.org/cl/431875 has been abandoned. GitHub PR #46029 has been closed. |
@ycongal-smile Looks like you might need to mark the CL as not abandoned? :/ |
I opened a new PR here : #55153 |
In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest
is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will
generate a proper RSA-PSS signature.
Pasted from the RSA-PSS handling code in CreateCertificate()
Fixes #45990