crypto/x509: fix certificate request creation with RSA-PSS #55153

ycongal-smile · 2022-09-19T17:50:41Z

In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest
is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will
generate a proper RSA-PSS signature.

Pasted from the RSA-PSS handling code in CreateCertificate().

Fixes #45990
Fixes #65074

ycongal-smile · 2022-09-19T17:52:06Z

Note: This is a copy of #46029 which seem to bother the bot.

gopherbot · 2022-09-19T17:55:09Z

This PR (HEAD: 2914abc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/431916 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-11-02T11:44:22Z

Message from Alex Scheel:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-01T19:24:02Z

Message from Yoann CONGAL:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-23T13:13:15Z

Message from Yoann CONGAL:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-06-27T08:39:53Z

This PR (HEAD: f7a5e2a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/431916 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-06-27T08:46:26Z

Message from Yoann CONGAL:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T13:11:39Z

This PR (HEAD: 37e1d50) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/431916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-04T13:25:09Z

Message from Yoann CONGAL:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T17:23:11Z

Message from Ian Lance Taylor:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T17:23:11Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-04T17:13:47Z","revision":"0c09cac56657acd42e0b2cf56e65d4ac704ae4bf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T17:35:29Z

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T17:35:30Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T17:35:31Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-04T18:11:39Z

Message from Yoann CONGAL:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T08:55:46Z

This PR (HEAD: 7386ca3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/431916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-06T09:10:32Z

Message from Yoann CONGAL:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-04T10:11:28Z

This PR (HEAD: b6cd51f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/431916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-04T10:19:16Z

Message from Yoann CONGAL:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T09:33:35Z

This PR (HEAD: 2b8681b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/431916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

ycongal-smile · 2024-01-02T09:34:43Z

No change, just rebased the branch and tested that the issue is still current (it is!)

gopherbot · 2024-01-02T09:40:19Z

Message from Yoann CONGAL:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T16:47:11Z

Message from Jes Cok:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T16:54:28Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T17:08:58Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

Updates golang#45990

In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will generate a proper RSA-PSS signature. Pasted from the RSA-PSS handling code in CreateCertificate() Fixes golang#45990

gopherbot · 2024-02-05T07:37:07Z

This PR (HEAD: 63fb021) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/431916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-05T07:43:27Z

Message from Yoann CONGAL:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:26:32Z

Message from Filippo Valsorda:

Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:33:28Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-16T09:20:09Z","revision":"859217eb0adf06f22e29caa4648982b68b05e5d9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:33:29Z

Message from Filippo Valsorda:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:33:30Z

Message from Go LUCI:

Patch Set 10:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 431916)
tools on master (commit b92578a)

Error:

failed to run "test golang.org/x/tools module": exit status 1
failed to run "test golang.org/x/tools/gopls module": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:33:30Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T09:33:31Z

Message from Filippo Valsorda:

Patch Set 10: TryBot-Bypass+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-16T13:23:57Z

Message from Dmitri Shuralyov:

Patch Set 10: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/431916.
After addressing review feedback, remember to publish your drafts!

In case of a RSA-PSS algorithm, the hashFunc of CreateCertificateRequest is embedded in a rsa.PSSOptions struct. Given to key.Sign(), this will generate a proper RSA-PSS signature. Pasted from the RSA-PSS handling code in CreateCertificate(). Fixes #45990 Fixes #65074 Change-Id: I8475afa79d8add107f092cc2871d38300e7b3903 GitHub-Last-Rev: 63fb021 GitHub-Pull-Request: #55153 Reviewed-on: https://go-review.googlesource.com/c/go/+/431916 Auto-Submit: Filippo Valsorda <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]> TryBot-Bypass: Filippo Valsorda <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Alex Scheel <[email protected]> Reviewed-by: Cherry Mui <[email protected]>

gopherbot · 2024-05-16T17:37:24Z

This PR is being closed because golang.org/cl/431916 has been merged.

ycongal-smile mentioned this pull request Sep 19, 2022

crypto/x509: fix certificate request creation with RSA-PSS #46029

Closed

ycongal-smile force-pushed the fix_rsapss_csr branch from 2914abc to f7a5e2a Compare June 27, 2023 08:36

ycongal-smile force-pushed the fix_rsapss_csr branch from f7a5e2a to 37e1d50 Compare September 4, 2023 13:08

ycongal-smile force-pushed the fix_rsapss_csr branch from 37e1d50 to 7386ca3 Compare November 6, 2023 08:50

ycongal-smile mentioned this pull request Nov 20, 2023

crypto/x509: can't verify signature on RSA-PSS certificate requests it created #45990

Closed

ycongal-smile force-pushed the fix_rsapss_csr branch from 7386ca3 to b6cd51f Compare December 4, 2023 10:08

ycongal-smile force-pushed the fix_rsapss_csr branch from b6cd51f to 2b8681b Compare January 2, 2024 09:32

ycongal-smile mentioned this pull request Jan 12, 2024

crypto/x509: provide crypto.SignerOpts to Sign in case of PSS signature #65077

Closed

ycongal-smile added 2 commits February 5, 2024 07:40

crypto/x509: add test for RSA-PSS-SHA256 CertificateRequest

1d33b53

Updates golang#45990

ycongal-smile force-pushed the fix_rsapss_csr branch from 2b8681b to 63fb021 Compare February 5, 2024 07:35

gopherbot closed this May 16, 2024

crypto/x509: fix certificate request creation with RSA-PSS #55153

crypto/x509: fix certificate request creation with RSA-PSS #55153

Conversation

ycongal-smile commented Sep 19, 2022 • edited by FiloSottile Loading

ycongal-smile commented Sep 19, 2022

gopherbot commented Sep 19, 2022

gopherbot commented Nov 2, 2022

gopherbot commented Feb 1, 2023

gopherbot commented Feb 23, 2023

gopherbot commented Jun 27, 2023

gopherbot commented Jun 27, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Sep 4, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Dec 4, 2023

gopherbot commented Dec 4, 2023

gopherbot commented Jan 2, 2024

ycongal-smile commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 12, 2024

gopherbot commented Jan 12, 2024

gopherbot commented Jan 12, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

gopherbot commented May 16, 2024

ycongal-smile commented Sep 19, 2022 •

edited by FiloSottile

Loading