-
Notifications
You must be signed in to change notification settings - Fork 18k
os: document that WriteFile is not atomic #56282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This adds the wording suggested by @KaithyRookie |
This PR (HEAD: e373adb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/443495 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Rob Pike: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
This PR (HEAD: 25367d9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/443495 to see it. Tip: You can toggle comments from me using the |
Message from Richard Finlay Tweed: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Update wording with that suggested by Rob Pike
Message from Richard Finlay Tweed: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
This PR (HEAD: 20d229f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/443495 to see it. Tip: You can toggle comments from me using the |
Message from Rob Pike: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Richard Finlay Tweed: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
This PR (HEAD: e3e31fa) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/443495 to see it. Tip: You can toggle comments from me using the |
Message from Rob Pike: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Ian Lance Taylor: Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Message from Rob Pike: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/443495. |
Fixes #56173 Change-Id: I03a3ad769c99c0bdb78b1d757173d630879fd4dd GitHub-Last-Rev: e3e31fa GitHub-Pull-Request: #56282 Reviewed-on: https://go-review.googlesource.com/c/go/+/443495 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Rob Pike <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/443495 has been merged. |
Fixes #56173