Skip to content

os: document that WriteFile is not atomic #56282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

os: document that WriteFile is not atomic #56282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e373adb
Issue 56173 document that WriteFile is not atomic
RichardoC Oct 17, 2022
25367d9
Address comments of excessive verboseness
RichardoC Oct 20, 2022
20d229f
Update file.go
RichardoC Nov 8, 2022
e3e31fa
Address trailing space
RichardoC Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/os/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,8 @@ func ReadFile(name string) ([]byte, error) {
// WriteFile writes data to the named file, creating it if necessary.
// If the file does not exist, WriteFile creates it with permissions perm (before umask);
// otherwise WriteFile truncates it before writing, without changing permissions.
// Since Writefile requires multiple system calls to complete, a failure mid-operation
// can leave the file in a partially written state.
func WriteFile(name string, data []byte, perm FileMode) error {
f, err := OpenFile(name, O_WRONLY|O_CREATE|O_TRUNC, perm)
if err != nil {
Expand Down