windows: add support for automatic delayed start in windows service #36

utkarsh-extc · 2019-07-23T10:55:29Z

No description provided.

googlebot · 2019-07-23T10:55:41Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

utkarsh-extc · 2019-07-23T10:59:19Z

I signed it!

googlebot · 2019-07-23T10:59:27Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gopherbot · 2019-07-23T11:01:14Z

This PR (HEAD: 8709355) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-23T11:02:14Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-23T18:59:07Z

This PR (HEAD: 0c73a91) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-24T04:48:58Z

Message from Ian Lance Taylor:

Patch Set 4:

I don't see any problems but I don't know this code. Alex, how does it look to you?

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-25T18:29:32Z

Message from Utkarsh Dixit:

Patch Set 4:

Patch Set 4:

I don't see any problems but I don't know this code. Alex, how does it look to you?

@[email protected]

Please add your comments

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-26T08:57:24Z

Message from Alex Brainman:

Patch Set 4:

(2 comments)

Please see below. Thank you.

Alex

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-26T10:19:37Z

This PR (HEAD: 611bc2d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-26T10:23:45Z

Message from Utkarsh Dixit:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-28T02:54:40Z

Message from Alex Brainman:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-28T09:05:03Z

This PR (HEAD: 02bcfa2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-28T09:05:59Z

This PR (HEAD: fc27f61) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-28T09:08:18Z

This PR (HEAD: 6190d90) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-28T09:14:09Z

Message from Utkarsh Dixit:

Patch Set 8:

Patch Set 5:

(1 comment)

DelayedAutoStart changed to bool, Updated test cases

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-31T09:23:37Z

Message from Alex Brainman:

Patch Set 8:

(5 comments)

Some more comments. Thank you.

Alex

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-02T02:06:11Z

This PR (HEAD: 2ed2934) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-02T02:14:46Z

This PR (HEAD: fabf33f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-02T02:22:42Z

Message from Utkarsh Dixit:

Patch Set 10:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-02T02:26:35Z

Message from Yasuhiro MATSUMOTO:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-02T02:30:59Z

This PR (HEAD: 8764fdb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187198 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-02T02:32:55Z

Message from Utkarsh Dixit:

Patch Set 11:

(1 comment)

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-04T05:35:55Z

Message from Alex Brainman:

Patch Set 11: Run-TryBot+1 Code-Review+2

LGTM once try-bots are happy.

Thank you very much.

Alex

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-04T05:36:48Z

Message from Gobot Gobot:

Patch Set 11:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=199195ae

Please don’t reply on this GitHub thread. Visit golang.org/cl/187198.
After addressing review feedback, remember to publish your drafts!

Change-Id: Iad33ea0f6627ac98c89dbaab0b41b3dd724c3163 GitHub-Last-Rev: 8764fdb GitHub-Pull-Request: #36 Reviewed-on: https://go-review.googlesource.com/c/sys/+/187198 Reviewed-by: Alex Brainman <[email protected]> Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

gopherbot · 2019-08-04T05:39:38Z

This PR is being closed because golang.org/cl/187198 has been merged.

utkarsh-extc added 4 commits July 23, 2019 15:36

add support for delayed automatic start

7e62a73

add support for delayed automatic service start

a9b5334

add support for delayed automatic service start

2baf3a6

add test for delayed start

8709355

googlebot added the cla: no label Jul 23, 2019

googlebot added cla: yes and removed cla: no labels Jul 23, 2019

utkarsh-extc changed the title ~~add support for automatic delayed start in windows service~~ sys/windows: add support for automatic delayed start in windows service Jul 23, 2019

utkarsh-extc changed the title ~~sys/windows: add support for automatic delayed start in windows service~~ windows: add support for automatic delayed start in windows service Jul 23, 2019

windows/svc: safe closure on error

0c73a91

Update config.go

611bc2d

Update config.go

02bcfa2

Update mgr.go

fc27f61

Update mgr_test.go

6190d90

Update mgr_test.go

2ed2934

Update config.go

fabf33f

Update config.go

8764fdb

gopherbot closed this Aug 4, 2019

windows: add support for automatic delayed start in windows service #36

windows: add support for automatic delayed start in windows service #36

Uh oh!

Conversation

utkarsh-extc commented Jul 23, 2019

Uh oh!

googlebot commented Jul 23, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

utkarsh-extc commented Jul 23, 2019

Uh oh!

googlebot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 24, 2019

Uh oh!

gopherbot commented Jul 25, 2019

Uh oh!

gopherbot commented Jul 26, 2019

Uh oh!

gopherbot commented Jul 26, 2019

Uh oh!

gopherbot commented Jul 26, 2019

Uh oh!

gopherbot commented Jul 28, 2019

Uh oh!

gopherbot commented Jul 28, 2019

Uh oh!

gopherbot commented Jul 28, 2019

Uh oh!

gopherbot commented Jul 28, 2019

Uh oh!

gopherbot commented Jul 28, 2019

Uh oh!

gopherbot commented Jul 31, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 2, 2019

Uh oh!

gopherbot commented Aug 4, 2019

Uh oh!

gopherbot commented Aug 4, 2019

Uh oh!

gopherbot commented Aug 4, 2019

Uh oh!

Uh oh!