Skip to content

Commit 76f7859

Browse files
committed
all: merge master (743372f) into gopls-release-branch.0.12
For golang/go#59818 Conflicts: - gopls/go.sum Merge List: + 2023-05-16 743372f gopls/internal/lsp/debug: limit to 100 recent trace entries + 2023-05-16 522243a go/ssa/interp: avoid hard-coding GOOS and GOARCH + 2023-05-16 a059382 gopls/internal/lsp/cache: fail workspace load on context cancellation + 2023-05-16 e5c8d4d gopls/internal/lsp/cache: unexport ValidBuildConfiguration + 2023-05-16 f4e8a71 go/ssa: use core type for composite literal addresses + 2023-05-16 3b25dbd go/ssa: use core types for array length + 2023-05-16 e7048d5 gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache + 2023-05-16 8c0fcd2 gopls/internal/lsp/lru: extract LRU logic to a standalone package + 2023-05-16 19d700c go/ssa/interp: use the actual GOOS and GOARCH to interpret tests + 2023-05-16 9dcd3d5 gopls/internal/lsp/filecache: limit Get parallelism too + 2023-05-16 7f203f0 go/ssa: consolidate use of underlying pointer + 2023-05-15 a13793e gopls/internal/lsp: add quick-fixes to manage the go.work file + 2023-05-15 12a0517 internal/gcimporter: improve error handling + 2023-05-15 5eb1eb9 gopls/internal/lsp/cache: call filecache.Set asynchronously + 2023-05-15 35fe77a gopls/internal/lsp/filecache: limit parallelism in Set + 2023-05-12 1c9fe3f gopls: improve diagnostics for orphaned files + 2023-05-12 ad74ff6 go/gcexportdata: drop support for the ancient binary format + 2023-05-11 01128f9 gopls/internal/lsp/source: fix bug renaming field to unexported + 2023-05-11 cd39d2b internal/lsp/cache: support loading multiple orphaned files + 2023-05-11 abeba28 gopls/internal/regtest/marker: support proxy files in marker tests + 2023-05-11 18186f0 go/analysis/passes/slog: simplify function matching + 2023-05-11 9aa9d13 cmd/bisect, internal/bisect: use more precise skip suffixes, written in hex + 2023-05-11 3034d9c gopls/internal/lsp/cmd: append, don't overwrite, in PublishDiagnostics + 2023-05-10 4318d63 gopls: change the default value of "symbolScope" to "all" + 2023-05-10 f44f50e gopls/internal/lsp/source: implementation: report builtin 'error' + 2023-05-10 787e720 gopls/internal/lsp: optimize checks for ignored files + 2023-05-10 4ed7de1 gopls: add google-cloud-go as a benchmark repo + 2023-05-10 d799eba gopls: additional instrumentation during goimports + 2023-05-10 a7e7dc4 go/ssa: rename test cases in TestGenericBodies + 2023-05-10 d668f58 gopls/internal/regtest/marker: require cgo for issue59944.txt + 2023-05-10 005fa64 go/analysis/passes/slog: add check for slog.Group + 2023-05-09 033e628 go/ssa: more reindentation of TestGenericBodies + 2023-05-09 2310848 go/ssa: reindent test cases in TestGenericBodies + 2023-05-09 90e9c65 gopls/internal/lsp/cache: skip type errors after parse errors + 2023-05-09 08b24db gopls/internal/lsp/regtest: check for "// @marker" rogue space + 2023-05-09 b9c20f6 gopls/internal/regtest/marker: migrate @diag to new marker tests + 2023-05-09 4609d79 cmd/bisect: add -compile and -godebug shorthands + 2023-05-09 ddfa220 internal/fuzzy: improvements to the symbol scoring algorithm + 2023-05-09 3449242 go/types/objectpath: don't panic when receiver is missing a method + 2023-05-08 0809ec2 gopls/internal/lsp/source: document {All,Workspace}Metadata + 2023-05-08 8f7fb01 go/analysis/unitchecker: add test of go vet on std + 2023-05-08 23e52a3 bisect: diagnose bad targets better + 2023-05-08 d5af889 gopls: set GOWORK=off for loads from debug and safetoken tests + 2023-05-08 c93329a go/analysis/passes/printf: reshorten diagnostic about %s in Println call + 2023-05-08 6219726 go.mod: update golang.org/x dependencies + 2023-05-08 f4d143e go/ssa: cleanup TestGenericBodies to pickup package name + 2023-05-08 3d99ebe gopls/diff/unified: remove redundant information + 2023-05-05 479f5c6 go/ssa: Origin is only available after building + 2023-05-05 6d1dd12 go/analysis: simplify unusedresult + 2023-05-05 4a2dd0d go/callgraph/vta: allow pointer to type parameter in sliceArrayElem + 2023-05-05 7c6c2b7 go/ssa: keep syntax for instantiations + 2023-05-05 ce1b96b all: fix some comments + 2023-05-05 0500fd4 go/ssa: use core type in address + 2023-05-05 8e9b185 gopls/internal/lsp/source: add the "symbolScope" option + 2023-05-05 4ac71c0 internal/imports: sort fixes for deterministic results + 2023-05-05 573915d gopls/internal/lsp/cache: always init the resolver in runProcessEnvFunc + 2023-05-05 dd09381 bisect: move to internal/bisect until API is reviewed + 2023-05-05 516063a bisect, cmd/bisect: add new library and tool + 2023-05-05 58fedf6 internal/diffp: add patience diff from main repo + 2023-05-04 7b684a9 gopls: port import tests to the new marker framework + 2023-05-04 87974e3 gopls/internal/lsp/filecache: skip TestConcurrency on plan9 builder + 2023-05-04 c64bb76 gopls/internal/lsp/source: make infertypeargs a convenience analyzer + 2023-05-04 91b7a8e go/ssa: use origin method in source lookup + 2023-05-03 ba892bb go/types/internal/play: show formatted AST + 2023-05-03 7df6af8 gopls/internal/lsp/filecache: silently discard CRC errors on macOS + 2023-05-02 2563079 go/analysis/passes/printf: update directive diagnostic message + 2023-05-02 3f6c3b3 gopls: upgrade to latest version of LSP protocol + 2023-05-02 216928d gopls: port function extraction marker tests to the new framework + 2023-05-02 2415ce1 gopls: skip tests that load gopls packages if x/tools replacement is missing + 2023-05-02 17e5ef3 gopls/internal/lsp/cache: remove cycle check from buildMetadata + 2023-05-02 affb5fc gopls/internal/lsp/source: fix crash in definitions of builtins + 2023-05-02 558d701 gopls/internal/lsp/source: fix another bug in reference expansion + 2023-05-01 51dfad7 gopls: port workspace/symbol marker tests to the new framework + 2023-05-01 c6b5780 gopls: fix build at older Go versions + 2023-05-01 7590fe4 gopls/internal/lsp: hover over linkname directives. + 2023-05-01 ec61ad3 gopls/internal/lsp/source: add invert-if-condition refactoring + 2023-04-28 5283a01 go/packages: delete TestCgoOption as it doesn't test the cgo option + 2023-04-28 e2f3b25 gopls/internal/bug: record bug reports in file cache + 2023-04-28 ab24b7b gopls/internal/regtest/marker: add a test case for issue #59554 + 2023-04-28 8235df3 gopls/internal/regtest/marker: port format tests to the new framework + 2023-04-28 80dc031 internal/diff: unified: match diff delete for empty file + 2023-04-27 165099b all: remove repeated definite articles + 2023-04-27 ac40903 internal/gocommand: simplify GoVersion invocation + 2023-04-27 9e0a7b1 copyright: don't require checkout to be named tools + 2023-04-26 94ed378 internal/lsp/testdata: update for new diagnostic from go list + 2023-04-26 a5c37ba gopls/internal/regtest/marker: skip on small machines + 2023-04-25 76e1037 internal/testenv: assume that mobile platforms are small machines + 2023-04-25 17e2d70 gopls/internal/bug: remove unused Data parameter + 2023-04-25 dd89a2e gopls/internal/lsp: remove now redundant debouncing logic + 2023-04-25 2a9398d go/analysis/passes/slog: do not report multiple incorrect keys + 2023-04-25 4baa3dc gopls/internal/bug: move bug package into gopls Change-Id: I4cb08fe593bbc00102dbd266ad4ef1b6a1150e08
2 parents ce09259 + 743372f commit 76f7859

File tree

380 files changed

+9926
-5716
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

380 files changed

+9926
-5716
lines changed

gopls/internal/lsp/cmd/test/cmdtest.go renamed to cmd/bisect/go119.go

+9-2
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,12 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
// Package cmdtest contains the test suite for the command line behavior of gopls.
6-
package cmdtest
5+
//go:build !go1.20
6+
7+
package main
8+
9+
import "os/exec"
10+
11+
func cmdInterrupt(cmd *exec.Cmd) {
12+
// cmd.Cancel and cmd.WaitDelay not available before Go 1.20.
13+
}

cmd/bisect/go120.go

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
// Copyright 2023 The Go Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style
3+
// license that can be found in the LICENSE file.
4+
5+
//go:build go1.20
6+
7+
package main
8+
9+
import (
10+
"os"
11+
"os/exec"
12+
"time"
13+
)
14+
15+
func cmdInterrupt(cmd *exec.Cmd) {
16+
cmd.Cancel = func() error {
17+
// On timeout, send interrupt,
18+
// in hopes of shutting down process tree.
19+
// Ignore errors sending signal; it's all best effort
20+
// and not even implemented on Windows.
21+
// TODO(rsc): Maybe use a new process group and kill the whole group?
22+
cmd.Process.Signal(os.Interrupt)
23+
return nil
24+
}
25+
cmd.WaitDelay = 2 * time.Second
26+
}

0 commit comments

Comments
 (0)