Compile cAdvisor statically #1237

luxas · 2016-04-22T20:01:38Z

Very simple fix for #1227
Also partially required for #1236

k8s-bot · 2016-04-22T20:02:05Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

luxas · 2016-04-22T20:04:29Z

Ahh, doesn't it recognize me? :)

Also cc @timstclair

vishh · 2016-04-22T20:25:48Z

ok to test

On Fri, Apr 22, 2016 at 1:04 PM, Lucas Käldström [email protected]
wrote:

Ahh, doesn't it recognize me? :)

Also cc @timstclair https://github.com/timstclair

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1237 (comment)

k8s-bot · 2016-04-22T20:28:19Z

Jenkins GCE e2e

Build/test passed for commit 61ee971.

Build Log

luxas · 2016-04-22T20:34:17Z

@vishh Tests passed. Are you confident enough to merge it 😄?
There will be time to evalute it before v0.24.0

vishh · 2016-04-22T20:39:28Z

@luxas The tests are not using the makefiles unfortunately. Look here. We need to make the test runner use the makefiles inorder to test this PR.

luxas · 2016-04-22T20:55:25Z

Argh, I see.
Will you set up an other CI or should I update the line you linked to?

vishh · 2016-04-22T21:46:04Z

Updating runner.go is the way to go.

On Fri, Apr 22, 2016 at 1:55 PM, Lucas Käldström [email protected]
wrote:

Argh, I see.
Will you set up an other CI or should I update the line you linked to?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1237 (comment)

k8s-bot · 2016-04-23T09:32:14Z

Jenkins GCE e2e

Build/test failed for commit e9a3c46.

Build Log

k8s-bot · 2016-04-23T09:34:48Z

Jenkins GCE e2e

Build/test failed for commit 73fbb57.

Build Log

k8s-bot · 2016-04-23T09:44:47Z

Jenkins GCE e2e

Build/test failed for commit c7e2e11.

Build Log

luxas · 2016-05-03T19:23:45Z

integration/runner/runner.go

@@ -204,7 +204,7 @@ func Run() error {

 	// Build cAdvisor.
 	glog.Infof("Building cAdvisor...")
-	err := RunCommand("godep", "go", "build", "github.com/google/cadvisor")
+	err := RunCommand("godep", "go", "build", "--ldflags='-extldflags \"-static\"'", "github.com/google/cadvisor")


@vishh Do you have any clue what to write here to make it work?
I tried a lot of different combinations, but the linker just didn't parse it.

Did you try running make build?

On Tue, May 3, 2016 at 12:23 PM, Lucas Käldström [email protected]
wrote:

In integration/runner/runner.go
#1237 (comment):

@@ -204,7 +204,7 @@ func Run() error {

// Build cAdvisor. glog.Infof("Building cAdvisor...")

err := RunCommand("godep", "go", "build", "github.com/google/cadvisor")

err := RunCommand("godep", "go", "build", "--ldflags='-extldflags "-static"'", "github.com/google/cadvisor")

@vishh https://github.com/vishh Do you have any clue what to write here
to make it work?
I tried a lot of different combinations, but the linker just didn't parse
it.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/google/cadvisor/pull/1237/files/c7e2e113a9084142964556bd76b43ffb64b9e0e9#r61940055

djtm · 2016-05-04T12:37:20Z

flag provided but not defined: -extldflags "-static"

Maybe it doesn't eat the =? ->

err := RunCommand("godep", "go", "build", "--ldflags", " '-extldflags \"-static\" ' ", "github.com/google/cadvisor")

Maybe we need not escape here.

err := RunCommand("godep", "go", "build", "--ldflags", " '-extldflags -static ' ", "github.com/google/cadvisor")

luxas · 2016-05-04T21:36:01Z

Thanks @djtm, will try it tomorrow

k8s-bot · 2016-05-05T15:03:25Z

Jenkins GCE e2e

Build/test failed for commit 48c87a6.

Build Log

luxas · 2016-05-05T15:32:04Z

It seems like a flake @vishh

luxas · 2016-05-05T15:34:07Z

@k8s-bot test this

k8s-bot · 2016-05-05T15:37:51Z

Jenkins GCE e2e

Build/test failed for commit 5b2bbd1.

Build Log

k8s-bot · 2016-05-05T15:45:56Z

Jenkins GCE e2e

Build/test failed for commit c339a0c.

Build Log

luxas · 2016-05-05T15:47:36Z

Seems like a ssh issue

vishh · 2016-05-05T18:22:14Z

@pwittrock ssh is failing (again)...

timstclair · 2016-05-06T23:47:34Z

@k8s-bot test this

k8s-bot · 2016-05-06T23:49:58Z

Jenkins GCE e2e

Build/test failed for commit c339a0c.

Build Log

pwittrock · 2016-05-07T00:03:35Z

Not obvious why this failed from the logs:

Error 1: error running cAdvisor: command "ssh" ["-i" "/var/lib/jenkins/gce_keys/google_compute_engine" "-o" "UserKnownHostsFile=/dev/null" "-o" "IdentitiesOnly=yes" "-o" "CheckHostIP=no" "-o" "StrictHostKeyChecking=no" "e2e-cadvisor-coreos-beta-docker19" "--" "sudo /tmp/cadvisor-3779/cadvisor --port 8080 --logtostderr --docker_env_metadata_whitelist=TEST_VAR &> /tmp/cadvisor-3779/log.txt"] failed with error: exit status 2 and output: Warning: Permanently added 'e2e-cadvisor-coreos-beta-docker19' (ECDSA) to the list of known hosts.

I can't tell if this is ssh or cadvisor that is failing.

devx · 2016-05-12T04:49:04Z

I tested manually, it seems like an SSH issue for me.

k8s-bot · 2016-05-16T20:12:19Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-16T20:26:24Z

Jenkins GCE e2e

Build/test failed for commit c339a0c.

Build Log

luxas · 2016-05-16T20:32:34Z

I don't think this is related to my PR:

Error 1: failed to make remote testing directory:

timstclair · 2016-05-16T20:59:40Z

No, sorry, our PR builder is broken right now. Fix is on the way.

luxas force-pushed the static_compilation branch from 61ee971 to e9a3c46 Compare April 23, 2016 09:31

luxas force-pushed the static_compilation branch from e9a3c46 to 73fbb57 Compare April 23, 2016 09:32

luxas force-pushed the static_compilation branch from 73fbb57 to c7e2e11 Compare April 23, 2016 09:42

luxas reviewed May 3, 2016
View reviewed changes

luxas mentioned this pull request May 4, 2016

Switch build.sh to a Makefile kubernetes/minikube#40

Closed

luxas force-pushed the static_compilation branch from c7e2e11 to 48c87a6 Compare May 5, 2016 15:00

luxas force-pushed the static_compilation branch from 48c87a6 to 5b2bbd1 Compare May 5, 2016 15:35

Compile cAdvisor statically

c339a0c

luxas force-pushed the static_compilation branch from 5b2bbd1 to c339a0c Compare May 5, 2016 15:42

luxas mentioned this pull request May 21, 2016

Link cAdvisor statically. #1299

Merged

luxas closed this May 21, 2016

djtm mentioned this pull request Jun 12, 2016

build failed on alpine linux 3.3 kubernetes/kubernetes#19464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile cAdvisor statically #1237

Compile cAdvisor statically #1237

luxas commented Apr 22, 2016

k8s-bot commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

k8s-bot commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

k8s-bot commented Apr 23, 2016

k8s-bot commented Apr 23, 2016

k8s-bot commented Apr 23, 2016

luxas May 3, 2016

vishh May 3, 2016

djtm commented May 4, 2016 •

edited

Loading

luxas commented May 4, 2016

k8s-bot commented May 5, 2016

luxas commented May 5, 2016

luxas commented May 5, 2016

k8s-bot commented May 5, 2016

k8s-bot commented May 5, 2016

luxas commented May 5, 2016

vishh commented May 5, 2016

timstclair commented May 6, 2016

k8s-bot commented May 6, 2016

pwittrock commented May 7, 2016

devx commented May 12, 2016

k8s-bot commented May 16, 2016

k8s-bot commented May 16, 2016

luxas commented May 16, 2016

timstclair commented May 16, 2016

Compile cAdvisor statically #1237

Compile cAdvisor statically #1237

Conversation

luxas commented Apr 22, 2016

k8s-bot commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

k8s-bot commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

luxas commented Apr 22, 2016

vishh commented Apr 22, 2016

k8s-bot commented Apr 23, 2016

k8s-bot commented Apr 23, 2016

k8s-bot commented Apr 23, 2016

luxas May 3, 2016

Choose a reason for hiding this comment

vishh May 3, 2016

Choose a reason for hiding this comment

djtm commented May 4, 2016 • edited Loading

luxas commented May 4, 2016

k8s-bot commented May 5, 2016

luxas commented May 5, 2016

luxas commented May 5, 2016

k8s-bot commented May 5, 2016

k8s-bot commented May 5, 2016

luxas commented May 5, 2016

vishh commented May 5, 2016

timstclair commented May 6, 2016

k8s-bot commented May 6, 2016

pwittrock commented May 7, 2016

devx commented May 12, 2016

k8s-bot commented May 16, 2016

k8s-bot commented May 16, 2016

luxas commented May 16, 2016

timstclair commented May 16, 2016

djtm commented May 4, 2016 •

edited

Loading