Link cAdvisor statically.

[vishh]

cc @mikedanese

[k8s-bot]

Jenkins GCE e2e

Build/test passed for commit 7f61276.

• Build Log

[timstclair]

What are the concerns around building this way? Is it just that it increases our shipping binary size?

[vishh]

It makes it possible to distribute cAdvisor & kubelet without requiring a
controlled base image.

On Fri, May 20, 2016 at 2:39 PM, Tim St. Clair [email protected]
wrote:

What are the concerns around building this way? Is it just that it
increases our shipping binary size?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1299 (comment)

[timstclair]

LGTM

[timstclair]

This won't affect kubelet though.

[vishh]

This PR won't. I'm working on a separate patch for k8s. AFAIK cAdvisor was
the main reason why we did not link statically.

On Fri, May 20, 2016 at 3:08 PM, Tim St. Clair [email protected]
wrote:

This won't affect kubelet though.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1299 (comment)

[luxas]

Seems like you forgot #1237, which was opened ages ago :( and failed due to internal flakes
However, I'm glad this is in, and I've been experimenting with linking kubelet statically...

[vishh]

Oops. Apologies. I sent out the PR while discussing kubelet distribution
issues with my colleagues.
I'm happy to revert this PR in favor of #1237 :)

On Sat, May 21, 2016 at 11:27 AM, Lucas Käldström [email protected]
wrote:

Seems like you forgot #1237 #1237,
which was opened ages ago :( and failed due to internal flakes
However, I'm glad this is in, and I've been experimenting with linking
kubelet statically...

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1299 (comment)

[luxas]

No no. This is good as-is :)
Instead, please review kubernetes/kubernetes#26028 :)

[djtm]

Ha, great. 👍