-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Format code with gofumpt #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, @alexandear! Thank you for doing this!
Of all the changes, the only one that I really don't like is the very last one: 0600 => 0o600
but I can live with that one. 😂
@willnorris - suddenly, with this one PR, I lost the ability to approve the two workflows EDIT: It looks like I may no longer have write access to the repo maybe? I'm not sure how I lost it. |
@google-admin - could you please add me back to the "Google" organization for this repo, as GitHub seems to have had some sort of glitch that kicked me out. |
Yeah, that's weird. It looks like I have basically the same security config as you (couple of passkeys, etc), and I still have access. (Also, when did GitHub add Login with Google? That's interesting... I never noticed that before) |
Weird indeed. Thanks for the confirmation.
Actually, I don't even remember. It must have been years ago. |
@google-admin - it has now been about 2 weeks that I have not had write access to this repo. Can you please restore my access? |
@google-admin - it has now been about 3 weeks that I have not had write access to this repo. Can you please restore my access? |
Thank you, @google-admin for restoring my access to this repo! It is greatly appreciated! TIL: My access was revoked because not only did I have "Passkeys" two-factor authentication enabled, but I ALSO had "SMS" two-factor authentication enabled. Apparently, my access was revoked because I had "SMS" 2FA enabled (which is considered less secure). I could not accept the invite for this repo until I REMOVED "SMS 2FA". Once I did that, I was able to accept the invite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @alexandear!
LGTM.
Merging.
This PR enables
gofumpt
formatter and formats all code withgolangci-lint fmt
.gofumpt
detects missing empty lines between functions like in #3687 (comment)