Skip to content

Conversation

Manas23601
Copy link
Contributor

@Manas23601 Manas23601 commented Aug 27, 2025

BREAKING CHANGE: ActionsBilling endpoints are removed.

Fixes: #3700.

  • Actions is now supported in enhanced billing only

Actions is now supported in enhanced billing only

convert struct fields to pass by value from pointers for easier processing
Copy link

google-cla bot commented Aug 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 27, 2025

Just FYI - I lost write access to this repo and this may cause unexpected delays for which I apologize.
You can watch that other PR to check on the status.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manas23601 - I'm confused as to why this:
https://docs.github.com/rest/billing/billing#get-github-actions-billing-for-an-organization
does not mention that the endpoint is no longer supported?

Can you please point to any official documentation that indicates that we should remove these methods/endpoints?

@Manas23601
Copy link
Contributor Author

I'm not able to do that for you. The API call redirects you to the enhanced billing platform API page. The API only returns GiTHub Actions cost.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 21, 2025

I'm not able to do that for you. The API call redirects you to the enhanced billing platform API page. The API only returns GiTHub Actions cost.

OK, thanks. Are you running this against an Enterprise version of GitHub, or the publicly-hosted service?
If what you are seeing is against an Enterprise version, then I don't think we may need to rethink our strategy.

@Manas23601
Copy link
Contributor Author

It is the public version, I tested it on a organisation Ii created.Also, I haven't tried this on an enterprise version.

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (3646f33) to head (7e02313).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
- Coverage   91.12%   91.11%   -0.02%     
==========================================
  Files         187      187              
  Lines       16640    16616      -24     
==========================================
- Hits        15164    15140      -24     
  Misses       1291     1291              
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title Remove BillingActions for User and Organisation chore!: Remove ActionsBilling endpoints for User and Organization Sep 23, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Manas23601!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell and/or @alexandear, might you have time for a code review? Thank you!

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 23, 2025
Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR's description by removing "convert struct fields to pass by value from pointers for easier processing".

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 25, 2025

Thank you, @alexandear! Done.
Merging.

@gmlewis gmlewis merged commit 0730270 into google:master Sep 25, 2025
7 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 25, 2025
@Manas23601
Copy link
Contributor Author

Thank you @gmlewis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecate] Billing for GitHub Actions is now supported in enhanced billing only.
3 participants