Merge NestedTeamsPreview branch to master #747
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
All CLAs signed. Changing label. |
gmlewis
added
cla: yes
|
libraryVersion needs bumping. |
googlebot
added
cla: no
and removed
cla: yes
gmlewis
added
cla: yes
|
@gmlewis Would you like me to do that in another PR? I can’t here. I realize now that I could have opened this PR myself. |
googlebot
added
cla: no
and removed
cla: yes
|
Thanks @elliotbeach, but I think we are good now. This has been a fun little exercise. |
gmlewis
added
cla: yes
github/orgs_teams.go
Outdated
| Description *string `json:"description,omitempty"` | ||
| Maintainers []string `json:"maintainers,omitempty"` | ||
| RepoNames []string `json:"repo_names,omitempty"` | ||
| ParentTeamID *string `json:"parent_team_id,omitempty"` |
There was a problem hiding this comment.
GitHub is expecting an integer, not a string. I've opened #748 to address that.
There was a problem hiding this comment.
To remove a team from the hierarchy and place it at the top level, GitHub allows the PATCH verb to be used with the body {"parent_team_id": null}. Is it possible with omitempty to send this kind of request right now?
But on the other hand, if we remove omitempty naively, we force ParentTeamID to be specified any time we edit the team, even if we only want to edit other attributes.
How do we balance both use cases? Is there prior art?
There was a problem hiding this comment.
@shurcooL Could we get your opinion on this point?
There was a problem hiding this comment.
Definitely similar to #236, thanks for referencing that @elliott-beach.
I suspect we'll need a separate method or something to force sending the null via another internal struct.
|
|
googlebot
added
cla: no
and removed
cla: yes
gmlewis
added
cla: yes
|
I will make a pull request to add a method for setting |
|
We'll need to resolve the conflict with I notice that d51e256 commit message says "Fixes #714.", but I don't see the new endpoint https://developer.github.com/v3/orgs/teams/#list-child-teams implemented yet. Doesn't that mean #714 is not going to be fully resolved yet? |
Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps #714.
This replaces Team with NewTeam in function that accept a team for creating or editing a team. The NewTeam struct is similar to the existing NewPullRequest for creating pull requests. We need a new struct because the set of parameters for creating or editing a team contains some parameters that are not in the parameter for teams, and most properties of teams cannot be used for editing. The specific change is that Teams are returned with a parent field, but are created/edited with a parent_id field. Helps #714.
Using the code as written in the `NestedTeamsPreview` branch produces an error when talking to the GitHub API: panic: PATCH https://github.com/api/teams/2514825: 422 Invalid request. For 'properties/parent_team_id', "2514824" is not a number or null. [] The documentation at https://developer.github.com/v3/orgs/teams/#create-team states that this parameter is an id type which appears to mean an integer, not a string. Also, id is an integer in the sample responses for Get team endpoint, etc.
Change-Id: I522f603a39882f7c1219af2571d616127f1b527f
dmitshur
force-pushed
the
NestedTeamsPreview
branch
from
fcf99d1 to
6f59276
Compare
googlebot
added
cla: no
and removed
cla: yes
|
I'm sorry, that Fix message was my fault... I thought it was resolved, but apparently not. |
|
It’s more my fault - I will fix tomorrow. |
|
@elliott-beach - what is the status here - as far as I can tell, I can squash and merge this, correct? |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Now that the |
|
OK, thank you, @shurcooL! I will squash and merge. |
* Add support for fetching parent team (for nested teams). (google#723) Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps google#714. * Add NewTeam struct. (google#724) This replaces Team with NewTeam in function that accept a team for creating or editing a team. The NewTeam struct is similar to the existing NewPullRequest for creating pull requests. We need a new struct because the set of parameters for creating or editing a team contains some parameters that are not in the parameter for teams, and most properties of teams cannot be used for editing. The specific change is that Teams are returned with a parent field, but are created/edited with a parent_id field. Helps google#714. * Add NestedTeamsPreview header to remaining endpoints Fixes google#714. * Change ParentTeamID field to int (from string). (google#748) Using the code as written in the `NestedTeamsPreview` branch produces an error when talking to the GitHub API: panic: PATCH https://github.com/api/teams/2514825: 422 Invalid request. For 'properties/parent_team_id', "2514824" is not a number or null. [] The documentation at https://developer.github.com/v3/orgs/teams/#create-team states that this parameter is an id type which appears to mean an integer, not a string. Also, id is an integer in the sample responses for Get team endpoint, etc. * Bump libraryVersion * NestedTeamsPreview: Add the ListChildTeams endpoint (google#758)
No description provided.