Skip to content

Fix "Unknown app_id" issue by resend "forwardGetListing" #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

nghiadhd
Copy link
Contributor

I fixed "Unknown app_id" issue by

Keep the app_id of "Safari"
Resend "forwardGetListing" with app_id of "Safari" if we meet "Unknown app_id"
I tested with 6 iOS devices (from 9.0.1 to 9.3.4) run in parallel with Appium

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nghiadhd
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@artygus artygus merged commit 9800ff8 into google:master Aug 22, 2016
@artygus
Copy link
Collaborator

artygus commented Aug 22, 2016

@nghiadhd thanks for contribution!

ssynix added a commit to ssynix/ios-webkit-debug-proxy that referenced this pull request Oct 11, 2016
ssynix added a commit to ssynix/ios-webkit-debug-proxy that referenced this pull request Oct 20, 2016
artygus added a commit that referenced this pull request Oct 20, 2016
Extending PR #155 to fix 'Unknown app_id' on WKWebViews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants