Skip to content

Extending PR #155 to fix 'Unknown app_id' on WKWebViews #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

ssynix
Copy link
Contributor

@ssynix ssynix commented Oct 20, 2016

We use ios-webkit-debug-proxy to automate webviews through Appium. IWDP seems to regularly get disconnected from the device during automation. #163 is exactly what's showing up on our IWDP logs.

I extended #155 to disregard the Safari restriction, and also copy app data on reportConnectedApplicationList. I'm not familiar enough with this project to understand the potential side-effects of this change, but it appears to have fixed the issue on my end!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@artygus artygus merged commit 4985874 into google:master Oct 20, 2016
@artygus
Copy link
Collaborator

artygus commented Oct 20, 2016

@ssynix thanks for the contribution!

@ssynix ssynix deleted the unknown_app_id_fix branch October 21, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants