This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Changes for compatibility with Python 3 #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can some please review this patch? Thank you! |
This was referenced Jun 21, 2016
Closed
| @@ -325,7 +325,7 @@ def __init__(self, list_sep): | |||
|
|
|||
| def Serialize(self, value): | |||
| """Serialize a list as a string, if possible, or as a unicode string.""" | |||
| output = cStringIO.StringIO() | |||
| output = io.StringIO() | |||
| writer = csv.writer(output) | |||
|
|
|||
| # csv.writer doesn't accept unicode, so we convert to UTF-8. | |||
There was a problem hiding this comment.
I believe there is a lurking bug on the following line when running in python3 (use of unicode keyword).
Instead, I believe you can replace all occurrences (there's only one) of CsvListSerializer(',') with ListSerializer(','). This prevents the need for importing the io module entirely.
vrusinov
added a commit
that referenced
this pull request
Jul 17, 2016
It is declares python2-only at the momens since there are still issues with python3 support. Related: - github pull request #22 - github pull request #26 - github pull request #29 - github issue #28 - github issue #20 Change on 2016/06/20 by vrusinov <[email protected]> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=125322335
|
take a look at the recent pushes, it should be working on Python 3. |
Thanks I'll close this PR then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for compatibility with Python 3