Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

For PyPI, add the supported versions of Python #26

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Apr 16, 2016

Are these the right versions?

Are these the right versions?
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cclauss
Copy link
Author

cclauss commented Apr 16, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@vrusinov
Copy link
Contributor

Sorry, I only saw your pull request now.

I am very sorry but we don't have technical ability to merge pull requests back (see https://github.com/google/python-gflags/blob/master/CONTRIBUTING.md). Can you please describe what are you trying to fix and I'll try to address in in next release?

@cclauss
Copy link
Author

cclauss commented Jun 3, 2016

The problem that I am trying to fix is that python-gflags is currently on the Python 3 Wall of Shame.

As one of the top 200 modules downloaded from PyPI, python-gflags is highly visible. python-gflags is red on python3wos because I believe that its PyPI record does not properly declare its Python 3 compatibility. If python-gflags is not compatible with Python 3 then it should be in red but if it does indeed support Python 3, the it should be in green.

@vrusinov
Copy link
Contributor

Gotcha. I'll run a few tests with python3 and update setup accordingly.

@nickjacobson
Copy link

nickjacobson commented Jun 21, 2016

The changes in #22 could help to make the library Python 3 compatible.

vrusinov added a commit that referenced this pull request Jul 17, 2016
It is declares python2-only at the momens since there are still issues with
python3 support.

Related:
 - github pull request #22
 - github pull request #26
 - github pull request #29
 - github issue #28
 - github issue #20

	Change on 2016/06/20 by vrusinov <[email protected]>

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=125322335
@vrusinov
Copy link
Contributor

Status update: I've declared python-gflags python2 only.
While I can make it "work" in python3 I would not be comfortable declaring it is supported. There are few fundamental changes needs to be done, specifically in bytes vs unicode/str area.

Since we don't have ability to accept pull requests to this project, I'm going to close this one and continue working on proper python3 support.

@vrusinov vrusinov closed this Jul 17, 2016
@Kurt-von-Laven
Copy link

Thank you for investigating Python 3 support, @vrusinov. Would it be possible to get a rough ETA? Is Ubuntu's version of gflags that supports Python 3 already on your radar?

@vrusinov
Copy link
Contributor

For anyone may see this pull request: I think Gregory summarized situation quite accurately in issue #20.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants