-
Notifications
You must be signed in to change notification settings - Fork 52
For PyPI, add the supported versions of Python #26
Conversation
Are these the right versions?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Sorry, I only saw your pull request now. I am very sorry but we don't have technical ability to merge pull requests back (see https://github.com/google/python-gflags/blob/master/CONTRIBUTING.md). Can you please describe what are you trying to fix and I'll try to address in in next release? |
The problem that I am trying to fix is that python-gflags is currently on the Python 3 Wall of Shame. As one of the top 200 modules downloaded from PyPI, python-gflags is highly visible. python-gflags is red on python3wos because I believe that its PyPI record does not properly declare its Python 3 compatibility. If python-gflags is not compatible with Python 3 then it should be in red but if it does indeed support Python 3, the it should be in green. |
Gotcha. I'll run a few tests with python3 and update setup accordingly. |
The changes in #22 could help to make the library Python 3 compatible. |
It is declares python2-only at the momens since there are still issues with python3 support. Related: - github pull request #22 - github pull request #26 - github pull request #29 - github issue #28 - github issue #20 Change on 2016/06/20 by vrusinov <[email protected]> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=125322335
Status update: I've declared python-gflags python2 only. Since we don't have ability to accept pull requests to this project, I'm going to close this one and continue working on proper python3 support. |
Thank you for investigating Python 3 support, @vrusinov. Would it be possible to get a rough ETA? Is Ubuntu's version of gflags that supports Python 3 already on your radar? |
For anyone may see this pull request: I think Gregory summarized situation quite accurately in issue #20. |
Are these the right versions?