Add validation changes to texture component swizzle proposal #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kangz Please review. |
|
Previews, as seen when this build job started (e0f841a): |
Kangz
reviewed
Jul 18, 2025
|
|
||
| ## Validation | ||
|
|
||
| A validation error happens if the swizzle is not the default and the `"texture-component-swizzle"` feature is enabled. |
There was a problem hiding this comment.
I don't think that this is what the group previously agreed to. If we add new things to the IDL, passing incorrect values in it will result in errors if the feature is not enabled. This is the same as when a new IDL dictionary member is added and JS code that happened to use it previously might start getting a TypeError.
There was a problem hiding this comment.
I meant "the "texture-component-swizzle" feature is not enabled" sorry
There was a problem hiding this comment.
I'll wait for the group to discuss and approve #5264 before merging.
mwyrzykowski
approved these changes
Jul 19, 2025
Kangz
approved these changes
Aug 4, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 5, 2025
This CL makes sure a validation error happens if the swizzle is not the default and the `"texture-component-swizzle"` feature is not enabled. Before, the validation error would occur for all types of swizzle when the feature would be disabled. Spec PR: gpuweb/gpuweb#5252 Bug: 414312052 Change-Id: I460ab817584356acb96bb2e1c1ddd0c1577997a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818591 Commit-Queue: Corentin Wallez <[email protected]> Reviewed-by: Corentin Wallez <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1496924}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5217 (comment) and #5217 (comment), this PR adds validation changes to the texture component swizzle proposal.