Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Simplify compactor alerts #292

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

gouthamve
Copy link
Contributor

We should simply alert on things not having run since X.

We should simply alert on things not having run since X.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve gouthamve requested a review from a team as a code owner April 20, 2021 15:04
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a comment about threshold, which I believe we can improve).

Co-authored-by: Marco Pracucci <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve gouthamve force-pushed the simplify-compactor-alerts branch from 8a4ba6d to addbf67 Compare April 20, 2021 16:22
@gouthamve gouthamve merged commit fedc5a7 into grafana:main Apr 20, 2021
@gouthamve gouthamve deleted the simplify-compactor-alerts branch April 20, 2021 16:29
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…-compactor-alerts

Simplify compactor alerts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants