This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fix CortexCompactorHasNotSuccessfullyRunCompaction to avoid false positives #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itives Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Apr 21, 2021
|
How long of a compaction run is considered bad? Is a compaction run taking 24hrs bad? Is a run taking 6hrs bad? |
There's no easy anwer. A compactor run loops until there's work to do. It may take forever and still catching up with the work, but run in a forever loop because as soon as it completes to compact a block there's more work to do. Realistically, we've observed 24h should be a threshold long enough. If compactor doesn't fully catch up in 24h, then you need to scale it up (vertically or horizontally). |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…tor-alert Fix CortexCompactorHasNotSuccessfullyRunCompaction to avoid false positives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Yesterday we merged #292 but I just realised it suffers false positives. The reason is that a compaction run is marked as done once there's no more work to do for the compactor. Because of this it could take even a long time (several hours) while the compactor is working flawlessly as expected. Moreover, after startup the metric
cortex_compactor_last_successful_run_timestamp_secondsvalue will be0until the first compaction run as completed (which, again, could take hours).In this PR:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]