Update AssemblyScript to 0.19.2 #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2021
evaporei
force-pushed
the
otavio/update-assembly-script
branch
8 times, most recently
from
c9d4162 to
b02cac8
Compare
evaporei
force-pushed
the
otavio/update-assembly-script
branch
5 times, most recently
from
b8496ce to
e13ca01
Compare
evaporei
force-pushed
the
otavio/update-assembly-script
branch
3 times, most recently
from
b8440a3 to
207d0f5
Compare
evaporei
force-pushed
the
otavio/update-assembly-script
branch
5 times, most recently
from
f100d50 to
9ecb156
Compare
This had to be done for now because the size_of is being called on AscPtr::read_ptr using the whole structure containing both versions, so the size is bigger.
Now we pass a flag (--explicitStart) to `asc` (AssemblyScript compiler) for it to export the `_start` funcion for us to call it manually. This is being done so the host-exports work properly.
…api version 0.0.5)
evaporei
force-pushed
the
otavio/update-assembly-script
branch
from
e3bc271 to
7f29b82
Compare
leoyvens
reviewed
Jul 15, 2021
| @@ -1,7 +1,9 @@ | |||
| import { Trigger } from "../generated/Contract/Contract"; | |||
| import { Address, BigDecimal, BigInt, ethereum } from "@graphprotocol/graph-ts"; | |||
|
|
|||
| // Test that host exports work in globals. | |||
| // TODO: remove this, graph-ts should guarantee this | |||
| __alloc(0); | |||
There was a problem hiding this comment.
Can this TODO be removed?
There was a problem hiding this comment.
Yes, this should be removed 😅
I'll remove both TODO and __alloc.
The __alloc should be called by my graph-ts branch.
leoyvens
approved these changes
Jul 15, 2021
|
Lets just squash the commits when merging |
…check of apiVersion 0.0.4
evaporei
commented
Jul 15, 2021
| // Sanity check | ||
| match &api_version { | ||
| api_version if *api_version <= Version::new(0, 0, 4) => { | ||
| // This was using an double equal sign before instead of less than. |
There was a problem hiding this comment.
@leoyvens here's the final comment I've talked about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows subgraph developers to use AssemblyScript on version
0.19.2. To enable the feature, they must change theirsubgraph.yaml'sapiVersionto a version greater than or equal to0.0.5. The behavior for the current deployed subgraphs shouldn't change at all.Before this is merged, we need to release a new version of both
graph-tsandgraph-cli, so we can point to them in theintegration-tests, for now they're using these PRs branches:Important changes: