Update AssemblyScript to 0.19.10 #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the tests soon, it seems that's because it's pointing to the wrong |
This was referenced Jun 15, 2021
evaporei
force-pushed
the
otavio/update-assembly-script
branch
from
114eea9 to
2fdab71
Compare
schmidsi
approved these changes
Jun 18, 2021
evaporei
force-pushed
the
otavio/update-assembly-script
branch
15 times, most recently
from
47f0bc3 to
ff558fe
Compare
evaporei
force-pushed
the
otavio/update-assembly-script
branch
5 times, most recently
from
fa64647 to
b829070
Compare
This isn't completly necessary, but version 10 isn't supported anymore and the new graph-ts version will support these three as well. Keeping it standardized seems a good fit :)
This needs to stay commented while we don't release a docker tag that can handle both versions of AssemblyScript in its runtime.
Sometimes the AssemblyScript compiler would crash and that is done internally by calling process.exit, which is terrible for catching errors. To fix this I've added a listener for the process.exit event, and I remove it if the compiler succeds.
… and graph-ts >0.21.0
Without this the tests would break because
manifest.{dataSources, templates} weren't Arrays so
they didn't have the Array.prototype.some method.
…Validation tests work
evaporei
force-pushed
the
otavio/update-assembly-script
branch
from
3ae1a69 to
d35134b
Compare
evaporei
force-pushed
the
otavio/update-assembly-script
branch
from
435b79e to
c81aac9
Compare
This is very important because before we would download graph-cli from the latest version to run the tests against it. However this is bad, because we could not be sure a new version passes against the tests from the example folder, since the release needed to be done before (it would go to master still pointing to the old version). This commit fixes the issue by pointing to the local graph-cli so that the example tests fail before we do a release. This also removes the necessity to bump the version everytime on these files.
evaporei
force-pushed
the
otavio/update-assembly-script
branch
from
c81aac9 to
bedf4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
package.jsonWhat's missing:
apiVersionisn't the one with the newestAssemblyScriptversionRelated PRs: