Implement outstanding tests

[jhgg]

This issue is just a check-list of outstanding tests I need to implement.

If you plan to help, please comment before starting work on any of these tests so we don't do the same work at the same time. If there's a name by the checkbox, that person is working on implementing those tests.

Type Tests

• @jhgg https://github.com/graphql/graphql-js/blob/master/src/type/__tests__/definition.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/type/__tests__/enumType.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/type/__tests__/introspection.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/type/__tests__/serialization.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/type/__tests__/validation.js Implement Type Validation #8

Executor Tests

• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/abstract.js
• https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/directives.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/executor.js (may be split between test_executor and test_concurrent_executor -- reconcile tests)
• https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/executor_schema.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/lists.js
• https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/mutations.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/nonnull.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/union-interface.js
• @jhgg https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/variables.js

Language Tests

• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/lexer.js graphql-python/graphql-core@6c52d0f
• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/parser.js
• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/printer.js
• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/schema-parser.js
• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/schema-printer.js
• https://github.com/graphql/graphql-js/blob/master/src/language/__tests__/visitor.js

Utility Tests

• https://github.com/graphql/graphql-js/blob/master/src/utilities/__tests__/astFromValue.js
• https://github.com/graphql/graphql-js/blob/master/src/utilities/__tests__/buildASTSchema.js
• https://github.com/graphql/graphql-js/blob/master/src/utilities/__tests__/buildClientSchema.js Implement Remaining Utilities #5
• https://github.com/graphql/graphql-js/blob/master/src/utilities/__tests__/getOperationAST.js
• https://github.com/graphql/graphql-js/blob/master/src/utilities/__tests__/schemaPrinter.js

Validation Tests

• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/ArgumentsOfCorrectType.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/DefaultValuesOfCorrectType.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/FieldsOnCorrectType.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/FragmentsOnCompositeTypes.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/KnownArgumentNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/KnownDirectives.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/KnownFragmentNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/KnownTypeNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/LoneAnonymousOperation.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/NoFragmentCycles.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/NoUndefinedVariables.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/NoUnusedFragments.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/NoUnusedVariables.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/OverlappingFieldsCanBeMerged.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/PossibleFragmentSpreads.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/ProvidedNonNullArguments.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/ScalarLeafs.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/UniqueArgumentNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/UniqueFragmentNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/UniqueInputFieldNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/UniqueOperationNames.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/VariablesAreInputTypes.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/VariablesInAllowedPosition.js
• https://github.com/graphql/graphql-js/tree/master/src/validation/__tests__/harness.js

Starwars

• https://github.com/graphql/graphql-js/blob/master/src/__tests__/starWarsQueryTests.js
• https://github.com/graphql/graphql-js/blob/master/src/__tests__/starWarsValidationTests.js

[rawls238]

wow this is great work @jhgg. Is there anything else we need to do to reach feature-parity with graphql-js?

[jhgg]

Nope. I just am working on finishing up the remaining executor tests. And we are good. It's done. Now to test and see where I messed up.

[jhgg]

@rawls238 you can read the release notes here for the current status: https://github.com/graphql-python/graphql-core/releases/tag/v0.4.7b0

[jhgg]

I could use some help with documenting things tho.