-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add explanation about argument name uniquess. #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to do these assertions in the same order as fields; i.e.
- Unique
- No
__
- Type check
thanks for you suggestion, it does more readable. |
Marking this proposal as Stage 1. Next steps are making sure this has a reflecting PR to the graphql.js reference implementation |
e5d241d
to
6c81ed8
Compare
Hi @leebyron @IvanGoncharov,would you be willing to merge this pr directly, or this process must finish in stage 3. I think it's a pretty simple supplementary explanation: the graphql implementation of various languages must obey it, but specification haven't written it directly. In fact, we can infer these validation rules from the specification. |
@dugenkui03 We need to go full process. I actually forgot about this PR so when working on graphql/graphql-wg#505 I independently did the same changes in #877 |
❌ Deploy Preview for graphql-spec-draft failed. 🔨 Explore the source changes: 3fcc954 🔍 Inspect the deploy log: https://app.netlify.com/sites/graphql-spec-draft/deploys/615e6aead8f9fa00072207cb |
@IvanGoncharov Thanks for your response. After |
@dugenkui03 Thanks, closing in favor of #891 |
Add explanation about argument name uniquess.