-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add explanation about argument name uniqueness. #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation about argument name uniqueness. #891
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Background graphql/graphql-wg#505 |
I think we are ready to move it to Stage2, but we still, need to follow the procedure and present it on WG. |
@IvanGoncharov Thank you so much that you can present it , my spoken english is not so good. I'd like join the meeting. |
@dugenkui03 Please add yourself to the agenda if you wish to attend, you do not need to speak other than introducing yourself at the beginning (and we can make an exception for that if you like?). If you wish, you may type into the Zoom chat and someone can read that out on your behalf. |
@benjie The PR was created to add myself to agenda, and I am glad to introduce myself briefly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go for the next WG, in my opinion: we should merge it in! It looks like @IvanGoncharov already created the rule for graphql-js
in graphql/graphql-js#3208, so I hope we can wrap this up quickly.
Can someone add it to the next WG agenda? |
b2742e3
to
10bb59a
Compare
I've merged the latest, did some tiny edits, and have added it to the next WG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels clear
Details in #739.