Minimize use of DUMMY_SP

[mcoffin]

Makes more meaningful feedback from macro builders.

Fixes (for ioreg, not for platformtree) #99

[farcaller]

We should have a lint warning for DUMMY_SP and unwrap() really.

[mcoffin]

While DUMMY_SP is pretty specific to compiler plugins (and I suspect it might be removed). I'll probably whip up an external lint plugin to check for unwrap().

[mcoffin]

@farcaller FYI
https://github.com/mcoffin/syntaxext_lint

Before this gets merged, I'll publish the dependency crate to crates.io and we can avoid depending on my version from github.

[farcaller]

👏

[mcoffin]

Slightly changing the scope of this PR to only minimize DUMMY_SP for ioreg since platformtree might be coming up on a rework.

No longer completely fixes #99, but it goes a long way towards doing so.

[hacknbot]

Can one of the admins verify this patch?

[farcaller]

ok to test

[mcoffin]

I can't see what went wrong with the jenkins build as it's behind a login screen. Probably just doesn't have the build script from the other branch?

[farcaller]

Exactly, didn’t have enough time to squash and merge, will do that in an hour is so. Then it just needs to be rebased.

[farcaller]

Okay, this can be rebased on master now.

[mcoffin]

Just got around to rebasing this as I'm pretty busy with finals through the end of the week. Opened #313 because of issues with the jenkins script.

[farcaller]

retest this please

[farcaller]

👍