Skip to content
This repository was archived by the owner on Jul 6, 2019. It is now read-only.

Ioreg improvements #300

Merged
merged 3 commits into from
Jun 27, 2015
Merged

Ioreg improvements #300

merged 3 commits into from
Jun 27, 2015

Conversation

farcaller
Copy link
Member

Added support for ignoring_state and placement getter, that allows code like this:

regs::SYSCON().sysoscctrl.ignoring_state()
    .set_bypass(regs::SYSCON_sysoscctrl_bypass::NOBYPASS)
    .set_freqrange(regs::SYSCON_sysoscctrl_freqrange::LOW);

mcoffin
mcoffin reviewed Jun 3, 2015
View reviewed changes
ioreg/src/builder/accessors.rs
-> P<ast::Item>
{
let reg_ty: P<ast::Ty> =
cx.ty_ident(DUMMY_SP, utils::path_ident(cx, path));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid hitting lint errors after #298 is done, should do

-DUMMY_SP
+reg.name.span

Because that's where the name of this register is derived from.

@farcaller
Copy link
Member Author

Will fix spans after #298 lands.

@farcaller farcaller mentioned this pull request Jun 9, 2015
Merged
@farcaller
Copy link
Member Author

anyone willing to give a look? /cc @bgamari @mcoffin

farcaller added a commit that referenced this pull request Jun 27, 2015
@farcaller
Merge pull request #300 from farcaller/ioreg
efbcef7 
Ioreg improvements
@farcaller farcaller merged commit efbcef7 into hackndev:master Jun 27, 2015
@farcaller farcaller deleted the ioreg branch June 27, 2015 08:37
@farcaller farcaller mentioned this pull request Jul 3, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farcaller @mcoffin @bharrisau