Skip to content

Warn about leading tabs #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Warn about leading tabs #5033

wants to merge 1 commit into from

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jan 14, 2018

There are 3957 warned files atm in Hackage index.
All of them have tab "inside the field", thus old parser acceps them.

See e.g added th-lift-instances file. The warning comes from the description field.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

There are 3957 warned files atm in Hackage index.
All of them have tab "inside the field", thus old parser acceps them.

See e.g added th-lift-instances file. The warning comes from the description field.
@phadej phadej added this to the 2.2 milestone Jan 14, 2018
@phadej phadej mentioned this pull request Jan 16, 2018
4 tasks
@phadej
Copy link
Collaborator Author

phadej commented Jan 16, 2018

Closed in favour of #5046

@phadej phadej closed this Jan 16, 2018
@phadej phadej deleted the leading-tabs branch January 16, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant