Prs 5028 5029 5033 #5046
Merged
Prs 5028 5029 5033 #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a provisional (i.e. hacky) retrofitted implementation of the forward-compat scheme described in haskell#4899 for the cabal-2.2 branch This hack works by constructing a dummy package description in case the package description fails to be parsed via the standard parser, and we detect a new-style cabal-spec declaration.
There are 3957 warned files atm in Hackage index. All of them have tab "inside the field", thus old parser acceps them. See e.g added th-lift-instances file. The warning comes from the description field.
This was referenced Jan 16, 2018
Also add FieldDescrs field grammar instance, for collecting individual field value parsers and printers.
|
@phadej You're on fire! |
|
It seems I burned Travis, hopefully they will recover soon :S |
|
linux and windows green. Merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #5028, #5029 and #5033.
This is last check before I hit merge.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!