Skip to content

Update the SPDX License List to version 3.16 #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022

Conversation

Kleidukos
Copy link
Member

@Kleidukos Kleidukos commented May 5, 2022

closes #8126


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@Kleidukos Kleidukos requested review from Mikolaj and gbaz May 5, 2022 18:15
@Kleidukos Kleidukos force-pushed the update-spdx-list-to-3-16 branch from 80a486e to d439483 Compare May 5, 2022 18:24
@andreabedini andreabedini self-requested a review May 5, 2022 23:07
Copy link
Collaborator

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kleidukos Kleidukos force-pushed the update-spdx-list-to-3-16 branch from d439483 to 038791a Compare May 5, 2022 23:13
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive. Is this done via a script and then verified? How is this verified/tested?

@Kleidukos
Copy link
Member Author

Kleidukos commented May 5, 2022

@Mikolaj Absolutely, the cabal-dev-scripts project has the gen-spdx and gen-spdx-exc executables to regenerate these lists from the JSON data that is provided. :)

@Mikolaj
Copy link
Member

Mikolaj commented May 6, 2022

@Kleidukos: and how is this modified code verified/tested?

@Kleidukos
Copy link
Member Author

@Mikolaj I learned the existence of this script yesterday evening, so I can't answer this. Maybe @gbaz has some insight?

@Mikolaj
Copy link
Member

Mikolaj commented May 9, 2022

@gbaz: any comments? If not, let's merge before it bit-rots. :)

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge IMHO.

@Kleidukos Kleidukos merged commit f26a066 into haskell:master May 10, 2022
@Kleidukos Kleidukos deleted the update-spdx-list-to-3-16 branch May 10, 2022 08:06
@fgaz
Copy link
Member

fgaz commented May 10, 2022

We'll have to remember to add the new licenses to cabal-version 3.8 (Cabal-syntax/src/Distribution/SPDX/LicenseListVersion.hs and doc/file-format-changelog.rst)

@fgaz
Copy link
Member

fgaz commented May 10, 2022

It looks like CabalSpecV3_8 already exists, so this is easily done. @Kleidukos could you open a follow-up pr with the necessary changes to the files I mentioned?

@gbaz
Copy link
Collaborator

gbaz commented May 10, 2022

for the record i have absolutely no insight as to the scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the SPDX License list to v3.16 (2022-02-06)
5 participants