Skip to content

Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2023
Merged

Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver #8794

merged 2 commits into from
Feb 23, 2023

Conversation

Kleidukos
Copy link
Member

@Kleidukos Kleidukos commented Feb 21, 2023 •
edited
Loading

(hopefully) closes #8715

Please include the following checklist in your PR:

@Kleidukos Kleidukos force-pushed the hecate-cabal-8715-remove-support-for-ghc-below-8 branch from 6e74c07 to 6464c50 Compare February 21, 2023 19:38
@Kleidukos Kleidukos changed the title Restrict the version of base to >=4.9. Disallow GHC <8.0 Feb 21, 2023
@Kleidukos Kleidukos changed the title Disallow GHC <8.0 Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver Feb 21, 2023
@Kleidukos Kleidukos requested a review from Mikolaj February 21, 2023 19:43
@ulysses4ever
Copy link
Collaborator

We recently dropped 8.2 from CI (leave alone 8.0): are we sure that all this stuff builds with those GHCs? Maybe we should raise the bar even higher, so to 8.4? I think it doesn't violate the support policy because that's what we checked when dropping 8.2...

@Mikolaj
Copy link
Member

Mikolaj commented Feb 21, 2023

We recently dropped 8.2 from CI (leave alone 8.0): are we sure that all this stuff builds with those GHCs? Maybe we should raise the bar even higher, so to 8.4? I think it doesn't violate the support policy because that's what we checked when dropping 8.2...

If they still build, no harm leaving the bounds permissive. Let's wait until somebody actually tries it and complains.

Mikolaj
Mikolaj approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 21, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@Kleidukos Kleidukos force-pushed the hecate-cabal-8715-remove-support-for-ghc-below-8 branch from d041a50 to 9ce338e Compare February 21, 2023 21:18
@Kleidukos Kleidukos force-pushed the hecate-cabal-8715-remove-support-for-ghc-below-8 branch from 9ce338e to 609856f Compare February 22, 2023 16:36
andreasabel
andreasabel reviewed Feb 22, 2023
View reviewed changes
cabal-testsuite/cabal-testsuite.cabal
@@ -26,7 +26,7 @@ common shared
default-language: Haskell2010

build-depends:
, base >= 4.6 && <4.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we conform this to <5 as in the other cases?
Especially in the testsuite we do not need more restrictive bounds than in the shipped products.
(Not really topic of this PR, but while we are at it...)

@andreasabel andreasabel added the re: dependencies Concerning Cabal's dependencies label Feb 22, 2023
@Kleidukos Kleidukos added squash+merge me Tell Mergify Bot to squash-merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Feb 23, 2023
@mergify mergify bot merged commit 9e417fa into haskell:master Feb 23, 2023
mergify bot pushed a commit that referenced this pull request Feb 23, 2023
@Kleidukos @mergify
Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver (#8794)
964049b 
* Disallow GHC <8.0

closes #8715

* Add changelog entry

(cherry picked from commit 9e417fa)
@mergify mergify bot mentioned this pull request Feb 23, 2023
Merged
mergify bot added a commit that referenced this pull request Feb 23, 2023
@mergify
Merge pull request #8798 from haskell/mergify/bp/3.10/pr-8794
105196f 
Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver (backport #8794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasabel andreasabel andreasabel left review comments

@Mikolaj Mikolaj Mikolaj approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days re: dependencies Concerning Cabal's dependencies squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cabal-syntax allows GHC-7.8 and GHC-7.10 buildplans
5 participants
@Kleidukos @ulysses4ever @Mikolaj @andreasabel @ffaf1