Skip to content

Disallow GHC <8.0 for Cabal{,-syntax} & cabal-install-solver #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cabal-syntax/Cabal-syntax.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ library

build-depends:
array >= 0.4.0.1 && < 0.6,
base >= 4.6 && < 5,
base >= 4.9 && < 5,
binary >= 0.7 && < 0.9,
bytestring >= 0.10.0.0 && < 0.12,
containers >= 0.5.0.0 && < 0.7,
Expand Down
2 changes: 1 addition & 1 deletion Cabal-tests/Cabal-tests.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ test-suite unit-tests
build-depends:
array
, async >=2.2.2 && <2.3
, base >=0 && <5
, base >=4.9 && <5
, binary
, bytestring
, Cabal
Expand Down
2 changes: 1 addition & 1 deletion Cabal/Cabal.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ library
build-depends:
Cabal-syntax ^>= 3.9,
array >= 0.4.0.1 && < 0.6,
base >= 4.6 && < 5,
base >= 4.9 && < 5,
bytestring >= 0.10.0.0 && < 0.12,
containers >= 0.5.0.0 && < 0.7,
deepseq >= 1.3.0.1 && < 1.5,
Expand Down
2 changes: 1 addition & 1 deletion cabal-install-solver/cabal-install-solver.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ library

if flag(debug-conflict-sets)
cpp-options: -DDEBUG_CONFLICT_SETS
build-depends: base >=4.8
build-depends: base >=4.9

if flag(debug-tracetree)
cpp-options: -DDEBUG_TRACETREE
Expand Down
2 changes: 1 addition & 1 deletion cabal-testsuite/cabal-testsuite.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ common shared
default-language: Haskell2010

build-depends:
, base >= 4.6 && <4.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we conform this to <5 as in the other cases?
Especially in the testsuite we do not need more restrictive bounds than in the shipped products.
(Not really topic of this PR, but while we are at it...)

, base >= 4.9 && <4.18
-- this needs to match the in-tree lib:Cabal version
, Cabal ^>= 3.9.0.0
, Cabal-syntax ^>= 3.9.0.0
Expand Down
10 changes: 10 additions & 0 deletions changelog.d/pr-8794
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
synopsis: Disallow GHC <8.0 for
packages: Cabal Cabal-syntax cabal-install-solver
prs: #8794
issues: #8715 #7531

description: {

Disallow GHC <8.0 by restricting the version of base that can be used to at least 4.9

}