Move process >= 1.16.4 constraint from Cabal-3.8.1.0 to cabal-install-3.8.1.0
#8802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI does not seem to run here. |
|
The |
Mikolaj
reviewed
Feb 27, 2023
Comment on lines
+31
to
+32
| , Cabal ^>=3.8.1.0 | ||
| , Cabal-syntax ^>=3.8.1.0 |
There was a problem hiding this comment.
We actually keep these, and everywhere else, at X.X.0.0 to avoid having to update at each minor release.
| zlib >= 0.5.3 && < 0.7, | ||
| hackage-security >= 0.6.2.0 && < 0.7, | ||
| text >= 1.2.3 && < 1.3, | ||
| text >= 1.2.3 && < 1.3 || >=2.0 && <2.1, |
There was a problem hiding this comment.
I don't remember --- was this tested with 3.8 (as opposed to with master)?
There was a problem hiding this comment.
I made this revision 2022-08-30. I strongly suspect that I did test it before revising.
But even if I hadn't, it has now passed the test of time. ;-)
There was a problem hiding this comment.
Hah, it did. But if so, I bet we tested it on 3.8 (or master before 3.8 has been cut).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8554.
This PR is not to be merged, just for testing and discussion, as agreed in the Cabal developers meeting of 2023-02-23.
The plan is to revise
Cabal-3.8.1.0andcabal-install-3.8.1.0according to this PR, namely the last 2 commits:The first commit just capture revisions already present on hackage. The second commit makes changes so that this PR builds.
I checked builds locally:
Cabalwithmtl-2.3.1(for 2beee0b)cabal-installwithunix-2.8.0.0(for aa60929)