Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Updated README installation instructions #998

Merged
merged 4 commits into from
Dec 17, 2018
Merged

Conversation

ianchanning
Copy link
Contributor

This are some modifications based on the confusion/problems I hit with #997.

  • Fedora library installation instructions
  • Added a step to check GHC version before installing
  • Handle each GHC version independently
  • Put the step to install all GHC versions at the end and with a warning for the installation size and time taken

This are some modifications based on the confusion/problems I hit with haskell#997. 

* Fedora library installation instructions 
* Added a step to check GHC version before installing
* Handle each GHC version independently 
* Put the step to install all GHC versions at the end and with a warning for the installation size and time taken
@alanz
Copy link
Collaborator

alanz commented Dec 16, 2018

The preferred installation mechanism is actually via the makefile, as it makes sure the repo is synced, installs the required cabal libraries if missing, and makes copies of the executables with suffixes to be able to tell them apart.

So stack install will install a single version of hie, and the hie-wrapper exe will then be useless.

So, the split out/reorganise makes sense, but the "active" command should be something like

make hie-8.6.2

Also, running just make prints a list of the available targets, including the compiler versions.

@ianchanning
Copy link
Contributor Author

Ah ok, sorry. I just blindly followed the commands in the README!

I'll have another try and re-submit.

I think the GHC version check step is still useful?

@alanz
Copy link
Collaborator

alanz commented Dec 16, 2018

I think clearly documenting how to install for just the versions of GHC you care about is a good thing. And that is basically what the version check does.

As [suggested][1] by @alanz, use `make` instead of `stack install`, more description for each OS. Completely separate the Windows section from the Linux section.

[1]: haskell#998 (comment)
Fix some of the links
@ianchanning
Copy link
Contributor Author

I've replaced all stack install steps with make plus with the addition of the hoogle docs for an individual version. I followed these steps as well to install both the v8.6.2 and v8.4.4 versions and tested them with a yesod project using Vim and Neovim.

@alanz
Copy link
Collaborator

alanz commented Dec 17, 2018

looks good, thanks for all the effort in doing this with verification.

@alanz alanz merged commit f1280dd into haskell:master Dec 17, 2018
@ianchanning
Copy link
Contributor Author

Great, glad to help!

@alanz alanz added this to the 2018-12 milestone Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants