Skip to content

Ignore ghcide tests by paths #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2021
Merged

Ignore ghcide tests by paths #1673

merged 4 commits into from
Apr 7, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Apr 6, 2021

  • If we only change ghcide downstream packages we have not test ghcide itself
  • Leveraging existing skip-duplicate-actions machinery

@jneira jneira requested review from pepeiborra and berberman April 6, 2021 08:30
Ailrun
Ailrun approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneira jneira added the merge me Label to trigger pull request merge label Apr 6, 2021
@berberman berberman merged commit c7fd931 into haskell:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@berberman berberman Awaiting requested review from berberman

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @Ailrun @berberman