Skip to content

Ignore ghcide tests by paths #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Ignore ghcide tests by paths #1673

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8eaf684
Ignore ghcide tests by paths
jneira Apr 6, 2021
e8cce6a
Merge branch 'master' into ignore-ghcide-test
jneira Apr 6, 2021
a05dcd7
Merge branch 'master' into ignore-ghcide-test
jneira Apr 6, 2021
cdef6ee
Merge branch 'master' into ignore-ghcide-test
berberman Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,18 @@ jobs:
runs-on: ubuntu-latest
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
should_skip_ghcide: ${{ steps.skip_ghcide_check.outputs.should_skip }}
steps:
- id: skip_check
uses: fkirc/[email protected]
with:
cancel_others: true
paths_ignore: '["**/docs/**", "**.md", "**/LICENSE", ".circleci/**", "install/**", "nix/**"]'
# If we only change ghcide downstream packages we have not test ghcide itself
- id: skip_ghcide_check
uses: fkirc/[email protected]
with:
paths_ignore: '["hls-test-utils/**", "plugins/**", "src/**", "exe/**", "test/**", "shake-bench/**"]'

test:
needs: pre_job
Expand Down Expand Up @@ -115,7 +121,7 @@ jobs:
# Retry it three times to workaround compiler segfaults in windows
run: cabal build || cabal build || cabal build

- if: ${{ needs.pre_job.outputs.should_skip != 'true' && matrix.test }}
- if: ${{ needs.pre_job.outputs.should_skip != 'true' && needs.pre_job.outputs.should_skip_ghcide != 'true' && matrix.test }}
name: Test ghcide
# run the tests without parallelism to avoid running out of memory
run: cabal test ghcide --test-options="-j1 --rerun-update" || cabal test ghcide --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test ghcide --test-options="-j1 --rerun"
Expand Down