hls-hlint-plugin work with GHC 9.6 #3552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
force-pushed
the
wip/hls-1.10-fixes
branch
2 times, most recently
from
81a1c1f to
3732153
Compare
|
This is still marked as draft, anything more needed here? |
This allows us to pick up Fourmolu 0.12.
wavewave
force-pushed
the
wavewave/ghc96-fourmolu-hlint
branch
from
968910b to
e1a7782
Compare
|
Oh. nothing more to work. sorry. It was a draft since it was on top of the other wip branch and I didn't realize it was merged. |
|
I've just seen this, after opening #3565 which heavily overlaps. Could we make this PR for HLint only? Since the other one is further along for Fourmolu, and in particular, I'm fairly sure is going to pass CI this time round. |
|
yeah. no problems. let's merge that #3565 first. Thanks! :-) |
…96-fourmolu-hlint
…into wavewave/ghc96-fourmolu-hlint
wavewave
changed the title
wavewave
changed the title
|
Obsolete as of #3677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so enable the flags and lift up buildable: False.