-
-
Notifications
You must be signed in to change notification settings - Fork 391
Allow Fourmolu 0.12 #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Fourmolu 0.12 #3565
Conversation
This allows us to pick up Fourmolu 0.12.
Since fourmolu-0.11.0.0 lack of some configuration, is it possible to remove this version from the candidate list? |
I'm not sure that removing it would really achieve much? 0.11 isn't actually buggy, and 0.12 even has the same default behaviour as 0.11 (fourmolu/fourmolu#304 just adds an off-by-default option). Besides, with The one slight annoyance here is GHC 9.0, which 0.12 drops support for due to the It seems the Nix builds are already constrained in this way. Is this for the same reason (1a8d8a2 is lacking some context)? If so, we should revert that commit for 9.2 at least. |
0.11 introduced a big format diff without any space for user to configure, it doesn't obey the fourmolu's principle: I pushed 1a8d8a2 just make CI to green without any version opinion😅
Agree, keeping v0.11 doesn't matter for me. |
Fair enough, but it's never going to be possible for that to be literally true!
Ah, okay, I don't really understand why it made a difference, but it doesn't matter now.
So, just to be clear, you're happy with this PR as-is? |
c03786d
to
f8f2f59
Compare
Sure, can't wait to use Fourmolu v0.12! |
No description provided.