Skip to content

Allow Fourmolu 0.12 #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Allow Fourmolu 0.12 #3565

merged 3 commits into from
Apr 22, 2023

Conversation

georgefst
Copy link
Collaborator

No description provided.

This allows us to pick up Fourmolu 0.12.
@July541
Copy link
Collaborator

July541 commented Apr 19, 2023

fourmolu/fourmolu#309

Since fourmolu-0.11.0.0 lack of some configuration, is it possible to remove this version from the candidate list?

@georgefst
Copy link
Collaborator Author

I'm not sure that removing it would really achieve much? 0.11 isn't actually buggy, and 0.12 even has the same default behaviour as 0.11 (fourmolu/fourmolu#304 just adds an off-by-default option). Besides, with index-state bumped, Cabal should always pick up 0.12 when possible.

The one slight annoyance here is GHC 9.0, which 0.12 drops support for due to the ghc-lib-parser bump. We could add if impl(ghc == 9.0) constraints: fourmolu ^>= 0.10 to cabal.project but then 9.0 users would miss out on other fixes from Fourmolu 0.11, and it wouldn't be obvious why. On the other hand, I don't think 9.0 is particularly heavily used anyway, since 9.2 was out before a lot of libraries supported it.

It seems the Nix builds are already constrained in this way. Is this for the same reason (1a8d8a2 is lacking some context)? If so, we should revert that commit for 9.2 at least.

@July541
Copy link
Collaborator

July541 commented Apr 19, 2023

0.11 isn't actually buggy

0.11 introduced a big format diff without any space for user to configure, it doesn't obey the fourmolu's principle: allows arbitrary configuration

I pushed 1a8d8a2 just make CI to green without any version opinion😅

Besides, with index-state bumped, Cabal should always pick up 0.12 when possible.

Agree, keeping v0.11 doesn't matter for me.

@georgefst
Copy link
Collaborator Author

0.11 introduced a big format diff without any space for user to configure, it doesn't obey the fourmolu's principle: allows arbitrary configuration

Fair enough, but it's never going to be possible for that to be literally true!

I pushed 1a8d8a2 just make CI to green without any version opinionsweat_smile

Ah, okay, I don't really understand why it made a difference, but it doesn't matter now.

Agree, keeping v0.11 doesn't matter for me.

So, just to be clear, you're happy with this PR as-is?

@July541
Copy link
Collaborator

July541 commented Apr 22, 2023

So, just to be clear, you're happy with this PR as-is?

Sure, can't wait to use Fourmolu v0.12!

@July541 July541 merged commit c5f7de0 into master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants