[rfc] new (better?) class & function filtering #698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a list of classes/functions downloaded from php.net (see included script) to determine if a function/class is HH-specific.
This results in a bunch of function/classes being added. See https://gist.github.com/jjergus/638f90531974f3b205dd5d025f855ffb for the full lists before/after and diff between them.
Most of the additions seem correct but there are some that we probably want to exclude (__hhvm_intrinsics, ImageMagick stuff, any others?).
We still use the original heuristics (in addition to the new list) -- these functions/classes would have been excluded if we only used the PHP list, but are included thanks to the heuristics: