Skip to content

fix examples #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2019
Merged

fix examples #699

merged 1 commit into from
Aug 5, 2019

Conversation

jjergus
Copy link
Contributor

@jjergus jjergus commented Aug 3, 2019

Examples are broken for

  1. all functions
  2. any class in a namespace
  3. any examples without code (.md only)

This fixes all of it, and adds a test.

Depends on #698, otherwise the test fails because we have examples for some classes that are currently not included in the docs!

@jjergus jjergus requested a review from fredemmott August 3, 2019 00:32
@fredemmott fredemmott mentioned this pull request Aug 5, 2019
Closed
@jjergus
fix examples
b84a0fc 
¯\_(ツ)_/¯
@jjergus jjergus merged commit e685509 into hhvm:master Aug 5, 2019
@jjergus jjergus deleted the fix-examples branch August 5, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredemmott fredemmott fredemmott approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjergus @fredemmott @facebook-github-bot