-
Notifications
You must be signed in to change notification settings - Fork 260
[BUG] New clone of repo shows modification to pure2-regex_10_escapes.cpp.execution
#1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
pure2-regex_10_escapes.cpp.execution
-- may have corrupt characters?pure2-regex_10_escapes.cpp.execution
This regex tests if escapes for special characters are handled properly. The main problem is the automatic change of the line ending of github. I updated the result file now several times and also got a bug report via mail. I think I should just simple remove this test. |
For those tests you should probably not output what is being matched but rather if it was matched, and integer ranges. |
I got the idea that I can just sanitize the outputs. I created a branch. #1224 |
I've been having problems with this file too and I thought my local git was corrupt -- it would not let me discard the "changes" and as a workaround I had to re-commit the file, otherwise I couldn't even change branches. Whew! It's just the file content, that's good news. Yes if we could fix this that would be grand. 🙏 |
The bugfix branch is ready to merge. |
Tested on Windows 11 and Ubuntu 22.04:
A new, fresh clone of the cppfront repo shows a change to
pure2-regex_10_escapes.cpp.execution
.Repro:
This message also appears in CI regarding the file:
However, I'm not convinced the problem is with the line endings because other
.execution
files appear to have CRLF endings.Instead I'm wondering if there's something in the file itself which is causing a problem. The GitHub preview stops printing the line numbers after line 38:
I had a look in Notepad++ and it shows the
\f
Form Feed,\a
Bell and\e
Esc characters, so maybe that confuses the GitHub preview.The text was updated successfully, but these errors were encountered: