Update for sanitizing regex results and matcher strings. #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSagebaum
changed the title
|
Letting the test suite run, so that I can update the test results. |
MaxSagebaum
force-pushed
the
bugfix/regex_result_output
branch
from
7cd2beb to
626ad0a
Compare
MaxSagebaum
changed the title
|
Thanks again for this! 🎉 |
|
Hmm, I just noticed that apparently as of this PR we broke a five regression test cases / compiler combinations? mixed-type-safety-1: on GCC 10, Clang 18 pure2-type-safety-1: on GCC 14, Clang 18 pure2-requires-clauses: on GCC 10 I might be misreading and it might not have been due to this PR, but if I'm reading it correctly these five files disappeared as of this PR? |
|
Ah, I see @filipsajdak has explained the reason in this comment: #1203 (comment) It seems to be a requires-clause thing, rather than something about this PR. I'll go take a look. Thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matcher strings and the result output for regular expression are now sanitized. Special characters like newline are replaced with the escaped version.
closes #1223