Use nio paths instead of strings #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTestDataMeta.groovy
# Conflicts: # CHANGELOG.md
sebastian-peter
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Looks quite good. I've only got some minor points. Plus, #540 should probably be handled first :)
src/test/groovy/edu/ie3/datamodel/io/connectors/CsvFileConnectorTest.groovy
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSourceIT.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSourceIT.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSourceTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSourceTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSourceTest.groovy
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java # src/main/java/edu/ie3/datamodel/io/csv/CsvFileDefinition.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSource.java
# Conflicts: # src/main/java/edu/ie3/datamodel/io/naming/FileHierarchy.java # src/main/java/edu/ie3/datamodel/io/naming/FileNamingStrategy.java
There was a problem hiding this comment.
@staudtMarius Wondering about your recent addition of FileDefinition, let's have a chat about it next week?
This reverts commit bcfd31b.
# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/datamodel/io/source/csv/CsvGraphicSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvRawGridSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvResultEntitySource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvThermalSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesMappingSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesMetaInformationSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvTypeSource.java # src/main/java/edu/ie3/datamodel/io/source/csv/CsvWeatherSource.java # src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvRawGridSourceTest.groovy
# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java # src/main/java/edu/ie3/datamodel/io/sink/CsvFileSink.java # src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy # src/test/groovy/edu/ie3/datamodel/io/source/csv/GridIoIT.groovy
sebastian-peter
requested changes
Jun 21, 2023
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvRawGridSourceTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/naming/FileNamingStrategyTest.groovy
Outdated
Show resolved
Hide resolved
sebastian-peter
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #723