-
Notifications
You must be signed in to change notification settings - Fork 5
Pp/#875 fix electricvehicle documentation #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pp/#875 fix electricvehicle documentation #992
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance, the entity model is missing a table row for qCharacteristics
(check EvInput.java
). Other than that, maybe @t-ober remembers what this issue was about.
The additional explanatory commentary you provided here does not seem necessary to me, as it is missing for (all) other documentation of system participants as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More precisely see here for whats going on: #993 (review) |
# Conflicts: # CHANGELOG.md
cc656d5
Has this Issue been processed before? I haven't noticed any significant changes.