Skip to content

Pp/#875 fix electricvehicle documentation #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

pierrepetersmeier
Copy link
Contributor

Has this Issue been processed before? I haven't noticed any significant changes.

@pierrepetersmeier pierrepetersmeier linked an issue Jan 24, 2024 that may be closed by this pull request
@pierrepetersmeier
Copy link
Contributor Author

  • added Remarks in docs/readthedocs/models/input/participant/ev.md and docs/readthedocs/models/result/participant/ev.md

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, the entity model is missing a table row for qCharacteristics (check EvInput.java). Other than that, maybe @t-ober remembers what this issue was about.

The additional explanatory commentary you provided here does not seem necessary to me, as it is missing for (all) other documentation of system participants as well.

staudtMarius
staudtMarius previously approved these changes Jan 29, 2024
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Jan 30, 2024
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing the description of the ev type attribute:

image

and the table for all type attributes, similar to lines and line types etc.

@t-ober t-ober self-requested a review February 1, 2024 12:43
@t-ober
Copy link
Contributor

t-ober commented Feb 1, 2024

We are missing the description of the ev type attribute:

image

and the table for all type attributes, similar to lines and line types etc.

Okay nevermind:

My PSDM docs link was outdated and brought me to some old version.. Sorry for the confusion!

t-ober
t-ober previously approved these changes Feb 1, 2024
@t-ober
Copy link
Contributor

t-ober commented Feb 1, 2024

We are missing the description of the ev type attribute:
image
and the table for all type attributes, similar to lines and line types etc.

Okay nevermind:

My PSDM docs link was outdated and brought me to some old version.. Sorry for the confusion!

More precisely see here for whats going on: #993 (review)

@sebastian-peter sebastian-peter dismissed stale reviews from t-ober and staudtMarius via cc656d5 February 1, 2024 16:00
@sebastian-peter sebastian-peter merged commit 4049dad into dev Feb 1, 2024
@sebastian-peter sebastian-peter deleted the pp/#875-fix-electricvehicle-documentation branch February 1, 2024 16:13
@sebastian-peter sebastian-peter added this to the Version 5.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ElectricVehicle Documentation
4 participants