Skip to content

Thermal House Documentation in docs not up to date #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2024
Merged

Thermal House Documentation in docs not up to date #993

merged 4 commits into from
Feb 1, 2024

Conversation

pierrepetersmeier
Copy link
Contributor

No description provided.

@pierrepetersmeier pierrepetersmeier linked an issue Jan 24, 2024 that may be closed by this pull request
Thermal House Documentation in docs not up to date #873
Closed
@pierrepetersmeier pierrepetersmeier changed the title !test Thermal House Documentation in docs not up to date #873 Jan 24, 2024
@pierrepetersmeier pierrepetersmeier changed the title Thermal House Documentation in docs not up to date #873 Thermal House Documentation in docs not up to date Jan 24, 2024
@pierrepetersmeier
Copy link
Contributor Author

pierrepetersmeier commented Jan 24, 2024 •
edited
Loading

-Added Remarks in docs/readthedocs/models/input/participant/thermalhouse.md
-Added Remarks and the Attribute "bus" in docs/readthedocs/models/result/participant/thermalhouse.md

@sebastian-peter
Copy link
Member

@t-ober Same question here, besides the one missing attribute, the doc does not seem quite different to the implementation. Maybe we're missing something?

@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Jan 30, 2024
t-ober
t-ober requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Okay there is weird stuff going on. When searching for Thermal House I get links to two models, the first one being an outdated earlier version. We should find out what is going on here. Please double check if that happens to you as well.

The same happens for electric vehicle:

image

This is also where the confusion in #992 comes from

@t-ober t-ober mentioned this pull request Feb 1, 2024
Merged
@t-ober
Copy link
Contributor

t-ober commented Feb 1, 2024

image

Okay there is weird stuff going on. When searching for Thermal House I get links to two models, the first one being an outdated earlier version. We should find out what is going on here. Please double check if that happens to you as well.

The same happens for electric vehicle:

image

This is also where the confusion in #992 comes from

Okay turns out i am just an idiot. As @sebastian-peter pointed out to me one is the input and one is the result model.

@t-ober t-ober merged commit be269cf into dev Feb 1, 2024
@t-ober t-ober deleted the pp/#873-thermal-house-documentation-in-docs-not-up-to-date branch February 1, 2024 15:53
@sebastian-peter sebastian-peter added this to the Version 5.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-ober t-ober t-ober approved these changes

Assignees

@pierrepetersmeier pierrepetersmeier

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging this pull request may close these issues.

Thermal House Documentation in docs not up to date
3 participants
@pierrepetersmeier @sebastian-peter @t-ober