Skip to content

Adding new feature to geo utils #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Conversation

staudtMarius
Copy link
Member

Resolves #320

@staudtMarius staudtMarius added the enhancement New feature or request label Nov 8, 2022
@staudtMarius staudtMarius self-assigned this Nov 8, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 67.31% // Head: 67.64% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (25992c1) compared to base (0e4e5d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #321      +/-   ##
============================================
+ Coverage     67.31%   67.64%   +0.33%     
- Complexity      231      232       +1     
============================================
  Files            40       40              
  Lines          1242     1255      +13     
  Branches        117      117              
============================================
+ Hits            836      849      +13     
  Misses          373      373              
  Partials         33       33              
Impacted Files Coverage Δ
...utils/src/main/java/edu/ie3/util/geo/GeoUtils.java 90.29% <0.00%> (+1.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@staudtMarius staudtMarius changed the title Ms/#320 adding new feature to geo utils Adding new feature to geo utils Nov 8, 2022
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this 🙂

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are some Codacy code style issues mostly related to groovy syntax features. It would be great if you could fix them otherwise I'm happy 🙂 .

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙂

@t-ober t-ober merged commit e7a8a02 into main Nov 25, 2022
@t-ober t-ober deleted the ms/#320-adding-new-feature-to-GeoUtils branch November 25, 2022 14:31
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new feature to GeoUtils
3 participants