-
-
Notifications
You must be signed in to change notification settings - Fork 206
chore: added code formatting settings for Positron/Air users #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
"editor.defaultFormatter": "positron.positron-r", | ||
"editor.formatOnType": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are actually not right. I'd encourage you to use usethis::use_air()
in the development version of usethis instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. you want these instead, which it sets up for you
https://github.com/tidyverse/dplyr/blob/main/.vscode/settings.json
https://github.com/tidyverse/dplyr/blob/main/.vscode/extensions.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right and I realize now that I have to rethink this. I turned Air of for igraph on purpose, because it did reformat old styling that was not supposed to be changed on a regular basis. So putting the air.toml in here but turning air off in the settings doesn't make much sense
Fix #1734
the
.vscode
folder contains custom styling rule for positron (might need to see if this needs to change for developers who use vscode, but not positron)air.toml
configures air to skip messing withgraph_from_literal
.