Skip to content

chore: added code formatting settings for Positron/Air users #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

schochastics
Copy link
Contributor

@schochastics schochastics commented Apr 9, 2025

Fix #1734

the .vscode folder contains custom styling rule for positron (might need to see if this needs to change for developers who use vscode, but not positron)

air.toml configures air to skip messing with graph_from_literal.

Copy link
Contributor

aviator-app bot commented Apr 9, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Comment on lines +3 to +4
"editor.defaultFormatter": "positron.positron-r",
"editor.formatOnType": true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually not right. I'd encourage you to use usethis::use_air() in the development version of usethis instead

Copy link

@DavisVaughan DavisVaughan Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right and I realize now that I have to rethink this. I turned Air of for igraph on purpose, because it did reformat old styling that was not supposed to be changed on a regular basis. So putting the air.toml in here but turning air off in the settings doesn't make much sense

@schochastics schochastics marked this pull request as draft April 10, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protect literals from Air
4 participants