Skip to content

chore: added code formatting settings for Positron/Air users #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: added code formatting settings for Positron/Air users #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54e2938
added formatting settings
schochastics Apr 9, 2025
1dce5fb
chore: Auto-update from GitHub Actions
schochastics Apr 9, 2025
287cbd9
Merge branch 'main' into code-formatting
krlmlr Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
^vendor\.sh$
^vendor-one\.sh$
^patch$
^\.vscode$
air.toml
^man/dot-igraph.progress\.Rd$
^man/dot-igraph.status\.Rd$
^man/dot-extract_constructor_and_modifiers\.Rd$
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
/version_number
igraph.Rcheck/
.venv/
.vscode/
.Rproj.user
/configure~
/src/build/
Expand Down
6 changes: 6 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"[r]": {
"editor.defaultFormatter": "positron.positron-r",
"editor.formatOnType": true
Comment on lines +3 to +4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually not right. I'd encourage you to use usethis::use_air() in the development version of usethis instead

Copy link

@DavisVaughan DavisVaughan Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. you want these instead, which it sets up for you

https://github.com/tidyverse/dplyr/blob/main/.vscode/settings.json
https://github.com/tidyverse/dplyr/blob/main/.vscode/extensions.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right and I realize now that I have to rethink this. I turned Air of for igraph on purpose, because it did reformat old styling that was not supposed to be changed on a regular basis. So putting the air.toml in here but turning air off in the settings doesn't make much sense

},
}
2 changes: 2 additions & 0 deletions air.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[format]
skip = ["graph_from_literal"]
Loading